Skip to content

Fix Sentry 1G11/1GB0/1GAA/1GCH/1GP0/1GZV/1GN4: async Reader paging count query #22863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nbradbury wants to merge 1 commit into
base: trunk
Choose a base branch
from
Draft

Fix Sentry 1G11/1GB0/1GAA/1GCH/1GP0/1GZV/1GN4: async Reader paging count query #22863

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 46 additions & 38 deletions WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderPostListFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,9 @@ import androidx.lifecycle.ViewModelProvider
import androidx.lifecycle.lifecycleScope
import androidx.lifecycle.repeatOnLifecycle
import androidx.recyclerview.widget.RecyclerView
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.launch
import kotlinx.coroutines.withContext
import com.google.android.material.R as MaterialR
import com.google.android.material.dialog.MaterialAlertDialogBuilder
import com.google.android.material.snackbar.Snackbar
Expand Down Expand Up @@ -255,56 +257,62 @@ class ReaderPostListFragment : ViewPagerFragment(), OnPostSelectedListener, OnFo
private var readerViewModel: ReaderViewModel? = null

/*
* called by post adapter to load older posts when user scrolls to the last post
* called by post adapter to load older posts when user scrolls to the last post.
* RecyclerView's GapWorker invokes this on the main thread; the count queries below
* park on the SQLite connection pool when it's busy, so do them on Dispatchers.IO
* and only resume on main to fire the (UI-touching) update calls.
*/
private val dataRequestedListener: DataRequestedListener = object : DataRequestedListener {
override fun onRequestData() {
// skip if update is already in progress
if (isUpdating) {
return
}

// request older posts unless we already have the max # to show
when (getPostListType()) {
ReaderPostListType.TAG_FOLLOWED,
ReaderPostListType.TAG_PREVIEW -> {
if (ReaderPostTable.getNumPostsWithTag(currentReaderTag) <
ReaderConstants.READER_MAX_POSTS_TO_DISPLAY
) {
// request older posts
updatePostsWithTag(
currentTag,
ReaderPostServiceStarter.UpdateAction.REQUEST_OLDER
)
readerTracker.track(AnalyticsTracker.Stat.READER_INFINITE_SCROLL)
val listType = getPostListType()
viewLifecycleOwner.lifecycleScope.launch {
when (listType) {
ReaderPostListType.TAG_FOLLOWED,
ReaderPostListType.TAG_PREVIEW -> {
val numPosts = withContext(Dispatchers.IO) {
ReaderPostTable.getNumPostsWithTag(currentReaderTag)
}
if (numPosts < ReaderConstants.READER_MAX_POSTS_TO_DISPLAY) {
updatePostsWithTag(
currentTag,
ReaderPostServiceStarter.UpdateAction.REQUEST_OLDER
)
readerTracker.track(AnalyticsTracker.Stat.READER_INFINITE_SCROLL)
}
}
}

ReaderPostListType.BLOG_PREVIEW -> {
val numPosts = if (currentFeedId != 0L) {
ReaderPostTable.getNumPostsInFeed(currentFeedId)
} else {
ReaderPostTable.getNumPostsInBlog(currentBlogId)
}
if (numPosts < ReaderConstants.READER_MAX_POSTS_TO_DISPLAY) {
updatePostsInCurrentBlogOrFeed(ReaderPostServiceStarter.UpdateAction.REQUEST_OLDER)
readerTracker.track(AnalyticsTracker.Stat.READER_INFINITE_SCROLL)
ReaderPostListType.BLOG_PREVIEW -> {
val numPosts = withContext(Dispatchers.IO) {
if (currentFeedId != 0L) {
ReaderPostTable.getNumPostsInFeed(currentFeedId)
} else {
ReaderPostTable.getNumPostsInBlog(currentBlogId)
}
}
if (numPosts < ReaderConstants.READER_MAX_POSTS_TO_DISPLAY) {
updatePostsInCurrentBlogOrFeed(ReaderPostServiceStarter.UpdateAction.REQUEST_OLDER)
readerTracker.track(AnalyticsTracker.Stat.READER_INFINITE_SCROLL)
}
}
}

ReaderPostListType.SEARCH_RESULTS -> {
val searchTag = ReaderUtils.getTagForSearchQuery(
currentSearchQuery!!
)
val offset = ReaderPostTable.getNumPostsWithTag(searchTag)
if (offset < ReaderConstants.READER_MAX_POSTS_TO_DISPLAY) {
updatePostsInCurrentSearch(offset)
readerTracker.track(AnalyticsTracker.Stat.READER_INFINITE_SCROLL)
ReaderPostListType.SEARCH_RESULTS -> {
val query = currentSearchQuery ?: return@launch
val searchTag = ReaderUtils.getTagForSearchQuery(query)
val offset = withContext(Dispatchers.IO) {
ReaderPostTable.getNumPostsWithTag(searchTag)
}
if (offset < ReaderConstants.READER_MAX_POSTS_TO_DISPLAY) {
updatePostsInCurrentSearch(offset)
readerTracker.track(AnalyticsTracker.Stat.READER_INFINITE_SCROLL)
}
}
}

else -> {
// noop
else -> {
// noop
}
}
}
}
Expand Down
Loading