-
Notifications
You must be signed in to change notification settings - Fork 33
Update dependency ruby to v4 #414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Greptile SummaryUpdated Ruby from 3.1.4/3.2 to 4.0.0 in local development ( Critical Issues:
Required Actions:
Confidence Score: 0/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant PR as Pull Request
participant CI as CI Workflow (ci.yml)
participant Release as Release Workflow (release.yml)
participant RubyGems as RubyGems.org
Dev->>PR: Updates .ruby-version to 4.0.0
Dev->>PR: Updates release.yml ruby-version to 4.0.0
PR->>CI: Triggers on pull_request
CI->>CI: Tests on Ruby 3.1 & 3.2 (not 4.0.0)
CI-->>PR: Test results (outdated Ruby versions)
Note over PR,Release: After merge to main
PR->>Release: Triggers on release event
Release->>Release: Uses Ruby 4.0.0 for build
Release->>Release: Runs rspec tests
Release->>Release: Builds gem
Release->>RubyGems: Publishes gem
Note over CI,Release: Version mismatch: CI tests 3.1/3.2<br/>but releases with 4.0.0
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, 2 comments
| - uses: ruby/setup-ruby@v1 | ||
| with: | ||
| ruby-version: '3.2' | ||
| ruby-version: '4.0.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: CI workflow (.github/workflows/ci.yml) still tests Ruby 3.1 and 3.2, while release uses 4.0.0 - creates mismatch between test and release environments
| ruby-version: '4.0.0' | |
| ruby-version: '3.2' |
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/release.yml
Line: 22:22
Comment:
**logic:** CI workflow (`.github/workflows/ci.yml`) still tests Ruby 3.1 and 3.2, while release uses 4.0.0 - creates mismatch between test and release environments
```suggestion
ruby-version: '3.2'
```
How can I resolve this? If you propose a fix, please make it concise.| @@ -1 +1 @@ | |||
| 3.1.4 | |||
| 4.0.0 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Verify all gem dependencies (jwt, encryptor, rubocop, etc.) are compatible with Ruby 4.0.0 before deploying
Prompt To Fix With AI
This is a comment left during a code review.
Path: .ruby-version
Line: 1:1
Comment:
**style:** Verify all gem dependencies (`jwt`, `encryptor`, `rubocop`, etc.) are compatible with Ruby 4.0.0 before deploying
How can I resolve this? If you propose a fix, please make it concise.
This PR contains the following updates:
3.1.4->4.0.03.2->4.0.0Release Notes
ruby/ruby (ruby)
v4.0.0: 4.0.0See also:
What's Changed
#io_writehook on IO flush by noteflakes · Pull Request #15609--with-ext=when ENABLE_SHARED=yes: ruby/digest.h not found for rubyspec CAPI extensions - Ruby - Ruby Issue Tracking SystemNote: This list is automatically generated by tool/gen-github-release.rb. Because of this, some commits may be missing.
Full Changelog
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.