Skip to content

Conversation

@TooAngel
Copy link
Contributor

@TooAngel TooAngel commented Dec 4, 2025

Summary

Root Cause

The workflow had:

- name: Check drift detection result
  if: steps.drift.outputs.exit_code != '0'
  run: |
    echo "⚠️ Drift detected..."
    exit 0  # <-- BUG: should be exit 1

This meant the job always passed regardless of the script's exit code.

@worlddriven
Copy link
Contributor

worlddriven bot commented Dec 4, 2025

🤖 Worlddriven Status

📊 Live Status Dashboard

🗓️ Merge Date: 2025-12-06 at 10:16:04 UTC (today)
📅 Started: 2025-12-04 at 21:20:41 UTC
Speed Factor: 0.15 (85% faster due to reviews)
Positive votes: 11/13 contribution weight (coefficient: 0.85)
📈 Base Merge Time: 10 days → Current: 2 days

🎯 Want to influence when this merges?

Your review matters! As a contributor to this project, your voice helps determine the merge timeline.

How to review:

  1. Check the changes
    Files changed

  2. Leave your review
    Review changes

Your options:

  • ✅ Agree & Speed Up: Approve Approving makes this merge faster
  • ❌ Disagree & Slow Down: Request changes Requesting changes delays the merge

💡 Pro tip: The more contributors who agree, the faster this gets merged!

📊 View detailed stats on the dashboard

📋 Recent Activity

2025-12-04, 21:04:44 - Pull request opened
2025-12-04, 21:04:45 - Pull request opened
2025-12-04, 21:20:48 - Branch synchronized (merge timer reset)
2025-12-04, 21:20:50 - Branch synchronized (merge timer reset)
2025-12-06, 10:52:15 - Pull request merged by worlddriven ✅


This comment is automatically updated by worlddriven

The previous fix (PR worlddriven#14) updated detect-drift.js to exit with code 1
when transfers are blocked due to missing permissions, but the workflow
file was never updated to propagate that failure.

The workflow had `exit 0` which always passed the job regardless of the
script's exit code. Changed to `exit 1` so the CI properly fails when
worlddriven lacks admin permission on source repositories.
@TooAngel TooAngel force-pushed the fix/workflow-exit-code branch from 4d93139 to 3e8ef5c Compare December 4, 2025 21:20
@worlddriven worlddriven bot merged commit 1435e7d into worlddriven:main Dec 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant