Skip to content

Fix plugin deactivation during force install with explicit --activate flag #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 7 commits into
base: main
Choose a base branch
from
+100 −16
Open

Fix plugin deactivation during force install with explicit --activate flag #500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6558cac
Initial plan
Copilot Feb 12, 2026
1cd40e6
Fix: Always activate plugin when --activate flag is used with install
Copilot Feb 12, 2026
5305959
Add tests for plugin activation with --force flag
Copilot Feb 12, 2026
f119a7a
Merge branch 'main' into copilot/fix-plugin-deactivation-after-update
swissspidy Feb 17, 2026
1b639da
Fix activation error handling when called from install
Copilot Feb 17, 2026
c13bbd5
Update tests to exercise the actual fix
Copilot Feb 17, 2026
6a597e4
Apply suggestions from code review
swissspidy Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 74 additions & 0 deletions features/plugin-install.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,3 +305,77 @@ Feature: Install WordPress plugins
"""
active
"""

Scenario: Install with --activate on already-active plugin should keep it activated
Given a WP install

When I run `wp plugin install hello-dolly --activate`
Then STDOUT should contain:
"""
Plugin 'hello-dolly' activated.
"""
And the return code should be 0

When I run `wp plugin list --name=hello-dolly --field=status`
Then STDOUT should be:
"""
active
"""

When I try `wp plugin install hello-dolly --activate`
Then STDERR should contain:
"""
Warning: hello-dolly: Plugin already installed.
"""
And STDOUT should contain:
"""
Activating 'hello-dolly'...
"""
And STDOUT should contain:
"""
Plugin 'hello-dolly' activated.
"""
And the return code should be 0

When I run `wp plugin list --name=hello-dolly --field=status`
Then STDOUT should be:
"""
active
"""

Scenario: Install with --activate-network on already-network-active plugin should keep it activated
Given a WP multisite install

When I run `wp plugin install hello-dolly --activate-network`
Then STDOUT should contain:
"""
Plugin 'hello-dolly' network activated.
"""
And the return code should be 0

When I run `wp plugin list --name=hello-dolly --field=status`
Then STDOUT should be:
"""
active-network
"""

When I try `wp plugin install hello-dolly --activate-network`
Then STDERR should contain:
"""
Warning: hello-dolly: Plugin already installed.
"""
And STDOUT should contain:
"""
Network-activating 'hello-dolly'...
"""
And STDOUT should contain:
"""
Plugin 'hello-dolly' network activated.
"""
And the return code should be 0

When I run `wp plugin list --name=hello-dolly --field=status`
Then STDOUT should be:
"""
active-network
"""
42 changes: 26 additions & 16 deletions src/Plugin_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,8 @@ public function activate( $args, $assoc_args = [] ) {
// If force flag is set, deactivate and reactivate to run activation hooks.
if ( $force ) {
deactivate_plugins( $plugin->file, false, true );
} else {
} elseif ( ! $this->chained_command ) {
// Only skip if not part of a chained command.
WP_CLI::warning( "Plugin '{$plugin->name}' is already network active." );
continue;
}
Expand All @@ -401,7 +402,8 @@ public function activate( $args, $assoc_args = [] ) {
// If force flag is set, deactivate and reactivate to run activation hooks.
if ( $force ) {
deactivate_plugins( $plugin->file, false, false );
} else {
} elseif ( ! $this->chained_command ) {
// Only skip if not part of a chained command.
WP_CLI::warning( "Plugin '{$plugin->name}' is already active." );
continue;
}
Expand All @@ -415,22 +417,30 @@ public function activate( $args, $assoc_args = [] ) {
$result = activate_plugin( $plugin->file, '', $network_wide );

if ( is_wp_error( $result ) ) {
$message = $result->get_error_message();
$message = (string) preg_replace( '/<a\s[^>]+>.*<\/a>/im', '', $message );
$message = wp_strip_all_tags( $message );
$message = str_replace( 'Error: ', '', $message );
WP_CLI::warning( "Failed to activate plugin. {$message}" );
// If the error is due to unexpected output, display it for debugging
if ( 'unexpected_output' === $result->get_error_code() ) {
/**
* @var string $output
*/
$output = $result->get_error_data();
if ( ! empty( $output ) ) {
WP_CLI::debug( "Unexpected output: {$output}", 'plugin' );
// When called from a chained command, treat 'already_active' as success.
// This handles race conditions where WordPress may have preserved activation
// status during the install process.
if ( $this->chained_command && 'plugin_already_active' === $result->get_error_code() ) {
$this->active_output( $plugin->name, $plugin->file, $network_wide, 'activate' );
++$successes;
} else {
$message = $result->get_error_message();
$message = (string) preg_replace( '/<a\s[^>]+>.*<\/a>/im', '', $message );
$message = wp_strip_all_tags( $message );
$message = str_replace( 'Error: ', '', $message );
WP_CLI::warning( "Failed to activate plugin. {$message}" );
// If the error is due to unexpected output, display it for debugging
if ( 'unexpected_output' === $result->get_error_code() ) {
/**
* @var string $output
*/
$output = $result->get_error_data();
if ( ! empty( $output ) ) {
WP_CLI::debug( "Unexpected output: {$output}", 'plugin' );
}
}
++$errors;
}
++$errors;
} else {
$this->active_output( $plugin->name, $plugin->file, $network_wide, 'activate' );
++$successes;
Expand Down
Loading