Use host check instead of substring search for GitLab URLs

[swissspidy]

Adding some hardening to make the check more robust.

Summary by CodeRabbit

• Bug Fixes
  • Improved GitLab repository detection for HTTPS and SSH URLs.
  • GitLab token authentication now works reliably with alternate URL casing and parsed hostnames.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d1285111-b4fa-44a0-be60-13a9a19874b0

📥 Commits

Reviewing files that changed from the base of the PR and between 6edd81a and 156c3d2.

📒 Files selected for processing (1)

• src/Package_Command.php

---

📝 Walkthrough

Walkthrough

GitLab token authentication now uses parsed URL hosts and available tokens. GitLab repository detection now recognizes HTTPS hosts regardless of casing and retains support for GitLab SSH URLs.

Changes

GitLab URL handling

Layer / File(s)	Summary
GitLab authentication and repository detection src/Package_Command.php	ZIP downloads and package lookups now apply GitLab token authentication correctly. Repository detection uses parsed HTTPS hosts and supports GitLab SSH URLs.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: copilot

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: replacing substring searches with host checks for GitLab URLs.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/host-check

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/Package_Command.php	0.00%	3 Missing ⚠️

📢 Thoughts on this report? Let us know!

[Copilot]

Pull request overview

This PR hardens GitLab URL detection in the package install/validation flow by switching from substring checks to host-based checks, making token/header injection decisions more robust and less error-prone.

Changes:

• Use parse_url(..., PHP_URL_HOST) + case-normalization to detect gitlab.com for attaching PRIVATE-TOKEN headers when downloading from GitLab URLs.
• Ensure GitLab fallback lookups in get_package_by_shortened_identifier() correctly apply GITLAB_TOKEN headers.
• Improve GitLab URL detection in check_git_package_name() by using host checks (and a stricter SSH prefix check).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.