Store the outer filesystem's filename in a constant for later use#649
Closed
johnpbloch wants to merge 3 commits intowp-cli:mainfrom
Closed
Store the outer filesystem's filename in a constant for later use#649johnpbloch wants to merge 3 commits intowp-cli:mainfrom
johnpbloch wants to merge 3 commits intowp-cli:mainfrom
Conversation
swissspidy
reviewed
Jul 14, 2024
Co-authored-by: Pascal Birchler <pascal.birchler@gmail.com>
Member
|
I don't think this approach is ideal. It is still very hacky and it has issues with multibyte strings in filesystems. I think this needs to be solved using https://www.php.net/manual/en/phar.running.php in the correct way. I'll have a stab at it... |
2 tasks
Member
|
Went with a different approach => #752 Thanks for looking into this, @johnpbloch ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to (and required for) wp-cli/wp-cli#5962
This will set an extra constant that stores the outer filesystem's filename. When that filename doesn't match with the phar's internal filename (wp-cli.phar), the phar can't find internal files that use
__DIR__for a reference point to the file.