Add backend timeout configuration for llm providers and mcp proxy#1328
Open
menakaj wants to merge 4 commits into
Open
Add backend timeout configuration for llm providers and mcp proxy#1328menakaj wants to merge 4 commits into
menakaj wants to merge 4 commits into
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (5)
📝 WalkthroughWalkthroughAdds configurable request and idle timeouts for LLM providers, LLM proxies, and MCP endpoints. The change spans API contracts, backend validation, persistence, deployment generation, console forms, and missing-record error handling. ChangesResilience timeout configuration
Estimated code review effort: 4 (Complex) | ~60 minutes Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (3 warnings)
✅ Passed checks (2 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@agent-manager-service/services/mcp_proxy_deployment.go`:
- Around line 459-476: Update the Main upstream extraction in the deployment
generation flow to copy main.Ref into upstream.Ref alongside the existing URL
mapping. Revise the validation error to state that either an upstream URL or Ref
is required, preserving the existing acceptance of either field.
In `@console/workspaces/pages/llm-providers/src/form/schema.ts`:
- Line 21: Update the duration validation regex used by DURATION_PATTERN in
console/workspaces/pages/llm-providers/src/form/schema.ts at lines 21-21 to
accept optional fractional values while preserving the existing units. Apply the
same regex change in
console/workspaces/pages/mcp-proxies/src/subComponents/EndpointFormFields.tsx at
lines 87-88, and reuse an exported shared constant if appropriate to avoid
duplication.
In
`@console/workspaces/pages/mcp-proxies/src/subComponents/MCPProxyConnectionTab.tsx`:
- Around line 48-49: Update the DURATION_PATTERN validation regex in
MCPProxyConnectionTab to accept an optional decimal fraction before the existing
ms, s, m, or h units, while preserving validation of integer durations and
rejecting malformed values.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: bb9bb7f4-7753-492a-bc64-b535cbea0420
⛔ Files ignored due to path filters (1)
cli/pkg/clients/amsvc/gen/types.gen.gois excluded by!**/gen/**
📒 Files selected for processing (39)
agent-manager-service/controllers/llm_controller.goagent-manager-service/docs/api_v1_openapi.yamlagent-manager-service/models/llm_provider.goagent-manager-service/models/llm_proxy.goagent-manager-service/models/mcp_proxy.goagent-manager-service/models/upstream.goagent-manager-service/models/upstream_test.goagent-manager-service/repositories/agent_configuration_repository.goagent-manager-service/repositories/env_agent_model_mapping_repository.goagent-manager-service/services/agent_configuration_service.goagent-manager-service/services/gateway_internal_service.goagent-manager-service/services/llm_deployment_service.goagent-manager-service/services/llm_deployment_service_test.goagent-manager-service/services/llm_provider_service.goagent-manager-service/services/llm_proxy_apikey_service.goagent-manager-service/services/llm_proxy_deployment_service.goagent-manager-service/services/llm_proxy_deployment_service_test.goagent-manager-service/services/llm_proxy_service.goagent-manager-service/services/mcp_proxy_deployment.goagent-manager-service/services/mcp_proxy_deployment_test.goagent-manager-service/services/mcp_proxy_service.goagent-manager-service/spec/model_create_llm_provider_request.goagent-manager-service/spec/model_llm_provider_response.goagent-manager-service/spec/model_llm_proxy_config.goagent-manager-service/spec/model_mcp_proxy_endpoint.goagent-manager-service/spec/model_resilience.goagent-manager-service/spec/model_update_llm_provider_request.goagent-manager-service/utils/spec_converter.goconsole/workspaces/libs/shared-component/src/components/ResilienceTimeoutFields.tsxconsole/workspaces/libs/shared-component/src/components/index.tsconsole/workspaces/libs/types/src/api/llm-providers.tsconsole/workspaces/libs/types/src/api/mcp-proxies.tsconsole/workspaces/pages/llm-providers/src/form/schema.tsconsole/workspaces/pages/llm-providers/src/subComponents/AddLLMProviderForm.tsxconsole/workspaces/pages/llm-providers/src/subComponents/LLMProviderConnectionTab.tsxconsole/workspaces/pages/llm-providers/src/utils/llmProviderPayload.tsconsole/workspaces/pages/mcp-proxies/src/subComponents/EndpointFormFields.tsxconsole/workspaces/pages/mcp-proxies/src/subComponents/MCPProxyConnectionTab.tsxconsole/workspaces/pages/mcp-proxies/src/subComponents/mcpEndpoints.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This should be merged after upgrading to the latest gateway. (1.2.0)
Resolves #828
Goals
Approach
User stories
Release note
Documentation
Training
Certification
Marketing
Automation tests
Security checks
Samples
Related PRs
Migrations (if applicable)
Test environment
Learning
Summary by CodeRabbit