feat: add imagePullSecrets.name to reference existing registry secrets

[AqeelMuhammad]

Summary

• Adds optional imagePullSecrets.name field to all chart values.yaml files (control-plane, traffic-manager, gateway, key-manager, all-in-one) and their default_values.yaml counterparts
• When imagePullSecrets.name is set, the chart uses the named pre-existing secret directly instead of creating a new kubernetes.io/dockerconfigjson Secret from credentials
• When imagePullSecrets.name is empty (default), existing credential-based behaviour is preserved — fully backward compatible

Motivation

Customers deploying APIM Helm charts in environments with centrally-managed image pull secrets (e.g. via Sealed Secrets, Vault, or corporate CI/CD pipelines) currently have no way to reference an existing secret by name. They must either supply raw credentials in values.yaml or modify chart source directly.

This change adds the missing name field alongside the existing username/password fields, making both workflows available without breaking any existing deployment.

Note: a similar change is proposed in #202 for main; this PR backports the equivalent fix to the 4.7.x branch.

Files changed

• distributed/*/values.yaml — added imagePullSecrets.name: ""
• distributed/*/templates/secrets/wso2am-secret-docker-registry.yaml — skip secret creation when name is set
• distributed/*/templates/*/deployment.yaml — reference named secret when name is set
• all-in-one/values.yaml, all-in-one/default_values.yaml, all-in-one/templates/... — same changes
• resources/am-pattern-*/default_*_values.yaml (16 files) — added imagePullSecrets.name: ""

Test plan

• helm lint passes on all 5 charts
• helm template with imagePullSecrets.enabled=true,name=my-secret shows imagePullSecrets: [{name: my-secret}] and no registry auth Secret rendered
• helm template with imagePullSecrets.enabled=true,username=u,password=p still renders the registry auth Secret and references it (backward compat)
• helm template with imagePullSecrets.enabled=false renders no imagePullSecrets field (unchanged)

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fce45724-20cf-4d2b-8138-8de573577772

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}