fix(content-script-context): handle undefined browser.runtime #2042
+20
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a browser extension context is fully invalidated (e.g., during extension update, reload, or disable), the `browser.runtime` object itself can become `undefined`, not just `browser.runtime.id`. This causes a runtime error when the `isInvalid` getter tries to access `browser.runtime.id`. This change adds optional chaining to safely handle the case where `browser.runtime` is undefined, preventing the error and allowing the content script to properly detect and handle context invalidation.
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When a browser extension context is fully invalidated (e.g., during extension update, reload, or disable), the
browser.runtimeobject itself can becomeundefined, not justbrowser.runtime.id. This causes a runtime error when theisInvalidgetter tries to accessbrowser.runtime.id.This change adds optional chaining to safely handle the case where
browser.runtimeis undefined, preventing the error and allowing the content script to properly detect and handle context invalidation.Manual Testing
Added automated tests for this scenario.
Related Issue
#1676
This PR closes #1676