build: stamp the release version into /api/version via ldflags#362
Merged
Conversation
httpapi.Version becomes a var (default "dev") set at image build with -X from the VERSION bake arg, which publish.yml already derives from the pushed tag. Fixes /api/version and the OpenAPI Info block reporting a hardcoded 0.1.0 on every build. "latest" (the no-tag default) stamps "dev" rather than masquerading as a version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
httpapi.Version becomes a var (default "dev") stamped at image build via the VERSION bake arg (publish.yml already derives it from the pushed tag). Fixes /api/version and the OpenAPI Info block reporting a hardcoded 0.1.0. Verified with
bake --print(prod stamps the tag, local stamps "dev") and an ldflags test build.