ctapi: Extend functionality with deletion, remote connection.#1
Open
brentoncollins wants to merge 1 commit intowz2b:mainfrom
Open
ctapi: Extend functionality with deletion, remote connection.#1brentoncollins wants to merge 1 commit intowz2b:mainfrom
brentoncollins wants to merge 1 commit intowz2b:mainfrom
Conversation
- `Delete` | `ctListDelete` function in `list.go`. - `CtOpenRemote` | `CtOpen` function to enable remote connections, created a new function. (Did not want to break anything you were already using). - Added `list_test.go` providing tests for connection handling, list operations (creation, addition, reading, and deletion), CITECT_DLL_PATH` environment variable to configure DLL paths for the test file. - Updated `find.go` and `init.go` to use `fmt.Fprintln` instead of `fmt.Println` for error formatting to comply with Go's standard (GO was complaining about it) - Tested with Aveva Plant Scada 2023 example project. Excellent work! I recently started investigating InfluxDB and came upon this project while researching how to create a Telegraf Plugin for the Citect API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete|ctListDeletefunction inlist.go.CtOpenRemote|CtOpenfunction to enable remote connections, created a new function. (Did not want to break anything you were already using).list_test.goproviding tests for connection handling, list operations (creation, addition, reading, and deletion), CITECT_DLL_PATH` environment variable to configure DLL paths for the test file.find.goandinit.goto usefmt.Fprintlninstead offmt.Printlnfor error formatting to comply with Go's standard (GO was complaining about it)Excellent work! I recently started investigating InfluxDB and came upon this project while researching how to create a Telegraf Plugin for the Citect API.