-
Notifications
You must be signed in to change notification settings - Fork 45
Add binary search implementation in C #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| /* | ||
| * binarySearch.c | ||
| * Simple iterative binary search in C. | ||
| * Reads number of elements, the sorted array, and a target value from stdin. | ||
| * Prints the index (0-based) if found, or a "not found" message otherwise. | ||
| */ | ||
|
|
||
| #include <stdio.h> | ||
| #include <stdlib.h> | ||
|
|
||
| int binary_search(int arr[], int n, int target) { | ||
| int lo = 0; | ||
| int hi = n - 1; | ||
| while (lo <= hi) { | ||
| int mid = lo + (hi - lo) / 2; | ||
| if (arr[mid] == target) return mid; // found | ||
| else if (arr[mid] < target) lo = mid + 1; | ||
| else hi = mid - 1; | ||
| } | ||
| return -1; // not found | ||
| } | ||
|
|
||
| int main(void) { | ||
| int n; | ||
| if (printf("Enter number of elements: ") < 0) return 1; | ||
| if (scanf("%d", &n) != 1 || n <= 0) { | ||
| fprintf(stderr, "Invalid number of elements.\n"); | ||
| return 1; | ||
| } | ||
|
|
||
| int *arr = malloc(sizeof(int) * n); | ||
| if (!arr) { | ||
| fprintf(stderr, "Memory allocation failed.\n"); | ||
| return 1; | ||
| } | ||
|
|
||
| printf("Enter %d sorted integers (ascending) separated by spaces or newlines:\n", n); | ||
| for (int i = 0; i < n; ++i) { | ||
| if (scanf("%d", &arr[i]) != 1) { | ||
| fprintf(stderr, "Failed to read array element %d.\n", i); | ||
| free(arr); | ||
| return 1; | ||
| } | ||
| } | ||
|
|
||
| int target; | ||
| if (printf("Enter value to search: ") < 0) { free(arr); return 1; } | ||
| if (scanf("%d", &target) != 1) { | ||
| fprintf(stderr, "Failed to read target value.\n"); | ||
| free(arr); | ||
| return 1; | ||
| } | ||
|
|
||
| int idx = binary_search(arr, n, target); | ||
| if (idx >= 0) { | ||
| printf("Element %d found at index %d (0-based).\n", target, idx); | ||
| } else { | ||
| printf("Element %d not found in the array.\n", target); | ||
| } | ||
|
|
||
| free(arr); | ||
| return 0; | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Error handling for printf is rarely necessary.
Consider removing the printf return value check to streamline the code, as output errors are highly unlikely in this context.