fix: automatically cleanup partial pgforge installations #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enhanced ensureDataDirectoryIsEmpty() to detect partial installations - Added intelligent detection of PostgreSQL/pgforge files and signatures - Automatic cleanup of detected partial installations without manual intervention - Improved error messages for unrecognized files with detailed file listing - Added safe recursive directory cleanup functionality Resolves issue where failed pgforge create attempts left directories in an unusable state requiring manual rm -rf cleanup. Co-authored-by: Samuel <xar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33 - "still getting not empty directory after changes"
Enhanced directory validation to automatically detect and cleanup partial pgforge installations without requiring manual
rm -rfcommands.Changes
ensureDataDirectoryIsEmpty()to detect partial installationsTesting
The fix ensures that failed
pgforge createattempts no longer leave directories in an unusable state.Generated with Claude Code