Skip to content

fix: PostgreSQL authentication issue during instance creation #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xar merged 1 commit into from
Jun 28, 2025
Merged

fix: PostgreSQL authentication issue during instance creation #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions src/instance/manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,25 +260,25 @@ export class InstanceManager {
console.log(`Temporary PostgreSQL process started with PID: ${tempProcess.pid}`);

// Wait for PostgreSQL to start
await this.waitForPostgreSQLReady(config.spec.network.port, config.spec.version);
await this.waitForPostgreSQLReady(config.spec.network.port, config.spec.version, socketDirectory);

console.log('PostgreSQL is ready, creating database and user...');

// Create the database
console.log(`Creating database: ${config.spec.database.name}`);
await this.execAsyncWithLogging(`${psqlPath} -h 127.0.0.1 -p ${config.spec.network.port} -U postgres -d postgres -c "CREATE DATABASE \\"${config.spec.database.name}\\""`);
await this.execAsyncWithLogging(`${psqlPath} -h "${socketDirectory}" -p ${config.spec.network.port} -U postgres -d postgres -c "CREATE DATABASE \\"${config.spec.database.name}\\""`);

// Create the user with password
console.log(`Creating user: ${config.spec.database.owner}`);
await this.execAsyncWithLogging(`${psqlPath} -h 127.0.0.1 -p ${config.spec.network.port} -U postgres -d postgres -c "CREATE USER \\"${config.spec.database.owner}\\" WITH PASSWORD '${password}'"`);
await this.execAsyncWithLogging(`${psqlPath} -h "${socketDirectory}" -p ${config.spec.network.port} -U postgres -d postgres -c "CREATE USER \\"${config.spec.database.owner}\\" WITH PASSWORD '${password}'"`);

// Grant privileges to the user on the database
console.log(`Granting database privileges...`);
await this.execAsyncWithLogging(`${psqlPath} -h 127.0.0.1 -p ${config.spec.network.port} -U postgres -d postgres -c "GRANT ALL PRIVILEGES ON DATABASE \\"${config.spec.database.name}\\" TO \\"${config.spec.database.owner}\\""`);
await this.execAsyncWithLogging(`${psqlPath} -h "${socketDirectory}" -p ${config.spec.network.port} -U postgres -d postgres -c "GRANT ALL PRIVILEGES ON DATABASE \\"${config.spec.database.name}\\" TO \\"${config.spec.database.owner}\\""`);

// Grant the user permission to create schemas in the database
console.log(`Granting schema creation privileges...`);
await this.execAsyncWithLogging(`${psqlPath} -h 127.0.0.1 -p ${config.spec.network.port} -U postgres -d "${config.spec.database.name}" -c "GRANT CREATE ON SCHEMA public TO \\"${config.spec.database.owner}\\""`);
await this.execAsyncWithLogging(`${psqlPath} -h "${socketDirectory}" -p ${config.spec.network.port} -U postgres -d "${config.spec.database.name}" -c "GRANT CREATE ON SCHEMA public TO \\"${config.spec.database.owner}\\""`);

console.log('Database and user created successfully');

Expand Down Expand Up @@ -356,15 +356,16 @@ export class InstanceManager {
return password;
}

private async waitForPostgreSQLReady(port: number, version: string, maxAttempts: number = 30): Promise<void> {
private async waitForPostgreSQLReady(port: number, version: string, socketDirectory: string, maxAttempts: number = 30): Promise<void> {
const psqlPath = await this.findPostgreSQLBinary('psql', version);
let lastError: any = null;

console.log(`Waiting for PostgreSQL to become ready on port ${port}...`);

for (let attempt = 1; attempt <= maxAttempts; attempt++) {
try {
const command = `${psqlPath} -h 127.0.0.1 -p ${port} -U postgres -d postgres -c "SELECT 1"`;
// Use Unix socket connection to avoid password authentication during temporary startup
const command = `${psqlPath} -h "${socketDirectory}" -p ${port} -U postgres -d postgres -c "SELECT 1"`;
console.log(`Attempt ${attempt}/${maxAttempts}: Testing PostgreSQL connection...`);

await execAsync(command, {
Expand Down