Fix three accuracy bugs in open_geotiff/to_geotiff#1082
Merged
brendancol merged 1 commit intomasterfrom Mar 29, 2026
Merged
Conversation
1. Windowed reads now respect PixelIsPoint raster type instead of unconditionally applying the half-pixel coordinate offset. 2. Custom CRS without EPSG codes are written to GeoAsciiParamsTag so they survive round-trips (previously silently dropped). 3. NaN pixels are converted back to the nodata sentinel value before writing, so the GDAL_NODATA tag matches the actual data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1081.
Summary
raster_typecorrectly, but the windowed override at line 216 always added the 0.5 offset. Fixed by adding the same check.write()only acceptedcrs_epsg: int. Addedcrs_wktpass-through tobuild_geo_tags, which stores the WKT in GeoAsciiParamsTag and sets the CRS GeoKey to 32767 (user-defined).open_geotiffconverts nodata sentinels to NaN, butto_geotiffwasn't converting them back. The written file would have NaN pixels but a GDAL_NODATA tag still pointing at the original sentinel (e.g. -9999). Fixed by restoring sentinel values from NaN before writing.Test plan
test_accuracy_1081.pycovering all three bugs