Automatically generate slug if not provided#38
Open
badrihippo wants to merge 1 commit intoxdamman:masterfrom
Open
Automatically generate slug if not provided#38badrihippo wants to merge 1 commit intoxdamman:masterfrom
badrihippo wants to merge 1 commit intoxdamman:masterfrom
Conversation
This is an issue with Medium drafts, where a slug is not set yet.
mediumexporter tries to save it using an empty string (""), which
results in a file named `.md` or the `images` folder being created
in the main content directory rather than in a subfolder.
By automatically setting the slug, mediumexporter can ensure that
each story gets saved in its own directory
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
=========================================
- Coverage 8.75% 8.69% -0.07%
=========================================
Files 2 2
Lines 274 276 +2
=========================================
Hits 24 24
- Misses 250 252 +2
Continue to review full report at Codecov.
|
Contributor
Author
|
@xdamman one more bugfix! I've got a third one coming up—should I continue submitting separately, or would you prefer them all bundled up into a single pull request? I'll probably have a few more since I'm using mediumexporter for my own project so ironing out creases as I find them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an issue with Medium drafts, where a slug is not set yet. mediumexporter tries to save it using an empty string (""), which results in a file named
.mdor theimagesfolder being created in the main content directory rather than in a subfolder.By automatically setting the slug, mediumexporter can ensure that each story gets saved in its own directory