Accept trailing key comments, fix option handling #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodecker
commented
Dec 15, 2015
rodecker
commented
- Accept trailing comments in key strings
- Fix option handling for port, all_hosts and algos
* Fix option handling for port, all_hosts and algos
|
The option handling fix is a real issue - I was about to submit a pull request for this when I saw there already was one. Without it, running sshfp without specifying the relevant arguments fails with unfriendly "NameError: global name 'XXX' is not defined" (for XXX in algos, all_hosts, ports) exceptions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.