add requests timeout value - prevent infinitely hanging requests#49
Open
innateessence wants to merge 1 commit intoxente:mainfrom
Open
add requests timeout value - prevent infinitely hanging requests#49innateessence wants to merge 1 commit intoxente:mainfrom
innateessence wants to merge 1 commit intoxente:mainfrom
Conversation
|
Author
|
@xente Looks like some check in the CI/CD pipeline isn't passing, if this is an issue that's blocking merging this change, let me know. Also, if you'd like anything changed, lmk |
Owner
|
Hi @innateessence sorry late response. I have disabled sonarqube by the moment. Looks like that your change has conflicts. Can you rebase from main, add into the README the new parameter and update the pr? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




This MR allows users to specify a timeout value for requests. An excerpt from the creators of the request library:
Nearly all production code should use this parameter in nearly all requests. Failure to do so can cause your program to hang indefinitely.https://docs.python-requests.org/en/latest/user/quickstart/#timeouts
Might be worth setting a default value for this.
I think:
is reasonable but I omitted that