Fix width on Icon.placeholder()#4456
Merged
Merged
Conversation
Member
|
This looks good to me - happy to get it in but wasn't sure as it was left in draft - thanks for jumping on this, sorry I missed it with the FA upgrade. Let's get it into our 86.2.0 release tomorrow. |
lbwexler
reviewed
Jun 25, 2026
| export function enhanceFaClasses(className: string, size: string) { | ||
| return classNames(className, 'fa-fw', 'xh-icon', isString(size) ? `fa-${size}` : null); | ||
| return classNames(className, 'xh-icon', isString(size) ? `fa-${size}` : null); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
fa-fw is deprecated per FA upgrade documentation. Icons now get a default width, making the class obsolete.
Member
|
Thanks much for this - noticed it fixes misalignment in ViewManager menu - active view has a checkmark icon, others should be aligned but had drifted over. Nice catch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply the correct width to the placeholder icon.
In previous versions of FontAwesome (FA), the
fa-fwclass was used to provide a standard width to all icons, and the icon placeholder, viaenhanceFaClasses.Starting with FA v7, all icons receive a standard width by default, and the
fa-fwclass is deprecated.The
xh-icon--placeholderclass that the icon placeholder already receives can be used to apply the same default width to the icon placeholders. In addition, thefa-fwclass can be removed fromenhanceFaClassessince it is deprecated.Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.
developbranch as of last change.If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.