Add Select generateOptionFn test examples and customer endpoint enhancements#829
Merged
Conversation
Add test examples for the new Select `lookupFn` prop to both the admin SelectTestPanel (desktop) and the mobile FormPage. Examples pre-populate selects with numeric ID values to verify that labels display on mount rather than raw IDs — the core scenario addressed by the `enhance-select-object-support` hoist-react branch. Desktop admin panel adds two cases: an options-based select with an ID not in the selectable list (resolved via `lookupFn`), and a queryFn-based select with `lookupFn`. Mobile form page adds matching employee and customer select fields with the same patterns. Extend the CustomerController and CustomerService to support lookup by `id` param and an `activeOnly` filter, enabling the `lookupFn` and filtered query test scenarios. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
6 tasks
…ect-support # Conflicts: # client-app/src/mobile/form/FormPage.ts # client-app/src/mobile/form/FormPageModel.ts
jskupsik
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test examples for the new Select
generateOptionFnprop to both the admin SelectTestPanel (desktop) and the mobile FormPage. Examples pre-populate selects with numeric ID values to verify that labels display on mount rather than raw IDs — the core scenario addressed by theenhance-select-object-supporthoist-react branch.Desktop admin panel adds two cases: an options-based select with an ID not in the selectable list (resolved via
generateOptionFn), and a queryFn-based select withgenerateOptionFn. Mobile form page adds matching employee and customer select fields with the same patterns.Extend the CustomerController and CustomerService to support lookup by
idparam and anactiveOnlyfilter, enabling thegenerateOptionFnand filtered query test scenarios.