Demo controls for fmtQuantity lossless + null precision#873
Open
lbwexler wants to merge 2 commits into
Open
Conversation
…ormats demo Wires up the Number Formats panel to exercise recent fmtNumber/fmtQuantity changes: - `lossless`, `useMillions`, `useBillions` switches, shown only when `fmtQuantity` is selected. - A `null` option on the precision picker, exercising `fmtNumber`'s full-precision handling. - Two sample values (7,100,100 and 7,120,000) that demonstrate the lossless cutoff. Depends on the `lossless` option from the corresponding hoist-react PR - run with inline hoist (or a snapshot that includes it) to see the new behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires up the Other › Format Numbers demo panel to exercise recent formatting changes from hoist-react.
Changes
lossless,useMillions, anduseBillionsswitches, shown only whenfmtQuantityis the selected formatter.nulloption to the precision picker, exercisingfmtNumber's new full-precision handling.7,100,100and7,120,000) that demonstrate the lossless cutoff (7,100,100stays full;7,120,000collapses cleanly to7.12m).Dependency
Depends on the
losslessoption added in the corresponding hoist-react PR. Run with inline hoist (or once a snapshot including it is published) to see the new behavior. Typecheck/lint pass against the current published snapshot since the options object is passed dynamically.