Fix prepare for project generators

[Shiffted]

fixes #6544

[gemini-code-assist]

Summary of Changes

Hello @Shiffted, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue related to project generators by ensuring that all targets are correctly prepared before their compilation commands and flags are generated. The fix involves integrating a prepare_targets() call into the compile_commands.lua script and importing the corresponding utility module in compile_flags.lua, which addresses a potential state management problem during the generation of project files.

Highlights

• Target Preparation: Introduced an explicit call to target_cmds.prepare_targets() within the make function in compile_commands.lua to ensure targets are properly initialized before generating the compile_commands.json file.
• Module Dependency: Added an import statement for the plugins.project.utils.target_cmds module in compile_flags.lua, making the necessary target preparation utilities available.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new step in the generation of compile_commands.json. It imports the target_cmds module in xmake/plugins/project/clang/compile_flags.lua and then calls target_cmds.prepare_targets() in xmake/plugins/project/clang/compile_commands.lua before the targets are added to the JSON file.

[Shiffted]

The target_cmds.prepare_targets() got removed here #6718 but this breaks module support since the scanner never gets called.

[Shiffted]

xmake/xmake/plugins/project/clang/compile_commands.lua

Line 204 in 40d790c

local key = hash.uuid(os.args(arguments_escape) .. sourcefile)

There also seems to be a problem with clang, it will add modules twice with different arguments, so the above check will not remove the duplicate. MSVC and GCC seem to work correctly.

[Shiffted]

There also seems to be a problem with clang, it will add modules twice with different arguments, so the above check will not remove the duplicate. MSVC and GCC seem to work correctly.

@Arthapz would it be correct here to disable two phase compilation when in the compile commands generator? It seems to break clang-tidy.

[Shiffted]

would it be correct here to disable two phase compilation when in the compile commands generator? It seems to break clang-tidy.

I will leave this for now as this was also the case before module support broke for compile commands. clangd seems to work with this and clang-tidy will output an error but still report the warnings.