RDKB-66095: WebConfig Subdoc Force Reset fails due to name truncation for longer strings - #264
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #264 +/- ##
=======================================
Coverage 82.97% 82.97%
=======================================
Files 38 38
Lines 11786 11786
Branches 1631 1631
=======================================
Hits 9780 9780
Misses 968 968
Partials 1038 1038 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR addresses RDKB-66095 by preventing truncation when parsing comma-separated subdocument names for the WebConfig “subdoc force reset” RBUS set handler.
Changes:
- Introduces
MAX_SUBDOC_COUNTandMAX_SUBDOC_NAME_LENconstants to standardize force-reset parsing limits. - Expands the temporary parsing buffers in
webcfgSubdocForceResetSetHandlerto avoid truncating longer subdoc name strings.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/webcfg_rbus.h | Adds shared constants to size subdoc parsing buffers consistently. |
| src/webcfg_rbus.c | Uses the new constants to enlarge parsing buffers for force-reset subdoc name handling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sadhyama
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.