Remove group mutex and related code and replace with GroupGuard where it was being used #2824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
How to use the Graphite Merge QueueAdd the label mergequeue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
tylerhawkes
force-pushed
the
group-locks
branch
from
f38f106 to
2f2c0e2
Compare
tylerhawkes
force-pushed
the
remove-group-mutex
branch
from
b61f715 to
01914d5
Compare
tylerhawkes
force-pushed
the
group-locks
branch
from
2f2c0e2 to
5683492
Compare
tylerhawkes
force-pushed
the
remove-group-mutex
branch
2 times, most recently
from
db73031 to
c302cab
Compare
tylerhawkes
force-pushed
the
group-locks
branch
from
5683492 to
c1a59b8
Compare
… it was being used
tylerhawkes
force-pushed
the
remove-group-mutex
branch
from
c302cab to
63eafd4
Compare
tylerhawkes
force-pushed
the
graphite-base/2824
branch
from
c1a59b8 to
ecc41cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove per-group mutexes and eliminate
MutexRegistryusage acrossxmtp_mls, replacing prior guards per the PR motivationDelete
MutexRegistry, removetokio::MutexfromMlsGroup, drop mutex accessors fromXmtpSharedContext, and stop locking inMlsGroup.sync_with_conn.📍Where to Start
Start with
MlsGroupconstruction and locking changes in xmtp_mls/src/groups/mod.rs, then reviewsync_with_connin xmtp_mls/src/groups/mls_sync.rs.Macroscope summarized 63eafd4.