Add reactions support and account autocreation#24
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Add XMTP message reactions and auto-provision missing account keys in
|
|
The formal models extracted constants ( This check is informational (not blocking merges yet). If this change is intentional, follow up by updating the formal models repo or regenerating the extracted artifacts there. |
| const conversationId = msgCtx.conversation?.id as string; | ||
| const isDirect = msgCtx.isDm(); |
There was a problem hiding this comment.
🟡 Medium
src/gateway-lifecycle.ts:148 conversationId is cast to string but msgCtx.conversation?.id can be undefined, causing a TypeError when .slice() is called later. Consider adding an early return if conversationId is falsy.
| const conversationId = msgCtx.conversation?.id as string; | |
| const isDirect = msgCtx.isDm(); | |
| const conversationId = msgCtx.conversation?.id as string; | |
| const isDirect = msgCtx.isDm(); | |
| if (!conversationId) return; |
🚀 Want me to fix this? Reply ex: "fix it for me".
🤖 Prompt for AI
In file extensions/xmtp/src/gateway-lifecycle.ts around lines 148-149:
`conversationId` is cast to `string` but `msgCtx.conversation?.id` can be `undefined`, causing a `TypeError` when `.slice()` is called later. Consider adding an early return if `conversationId` is falsy.

Summary
Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
User-visible / Behavior Changes
reactavailable for XMTP messages with parameters:to,messageId,emoji, and optionalremoveSecurity Impact (required)
Yes)Yes)Yes)No)No)Yes, explain risk + mitigation:Repro + Verification
Environment
Steps
reactactionExpected
Actual
Evidence
Human Verification (required)
What you personally verified (not just CI), and how:
Compatibility / Migration
Yes)No)No)Failure Recovery (if this breaks)
Risks and Mitigations