Open
Conversation
nineinchnick
commented
Mar 22, 2021
nineinchnick
commented
Mar 22, 2021
nineinchnick
commented
Mar 22, 2021
Member
|
I see that you're working on this. Please hold off on merging this to master for now. I'm almost done with the changes, and this will very likely create conflicts. I'll work with you after the other changes I've made are in |
Member
Author
|
No problem, I don't mind resolving conflicts. As this PR has some significant changes, I wouldn't have merged it without review anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greatly reduce memory allocations. Unfortunately, CPU usage is only slightly lower.
Summary of changes:
sync.PoolforValuesand free them after done drawing, headers are not freedScan(), but the row slice of[]*Valueis not yet reused/pooledrowStyles, especially because there's a custom function to avoid callingbytes.Repeatfor fillers, fillers' capacity now expands and is reusedNote that the (recently implemented)
TemplateEncoderdoesn't free Values at all, because it's sending rows over a channel and it doesn't know when the template executor is done processing them. I tried to leverage the fact that the channel is non-buffered, but couldn't make it work.Before:
After:
Closes xo/usql#144