docs: correct stale handler docstrings to match implemented behavior#3
Merged
Conversation
The semantic-tokens and code-action handlers carried docstrings from an earlier "slice" state, claiming the visitor emits no tokens and the code-action handler returns an empty list. Both are fully implemented: AstVisitor emits keywords/vars/strings/comments/declaration names and typeParameter for generic T, and the code-action handler merges import, diagnostic-fix, and optimize-imports providers. Also correct codeAction/resolve's rationale: it is a no-op because actions attach their WorkspaceEdit eagerly (no round-trip needed), not because the action list is empty. Genuine remaining limitations (byte-vs-UTF-16 token length, interpolation granularity) are reworded, not removed. Comment-only; no behavior change. Suite green (889 tests). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The semantic-tokens and code-action handlers carried docstrings from an earlier "slice" state, claiming the visitor emits no tokens and the code-action handler returns an empty list. Both are fully implemented: AstVisitor emits keywords/vars/strings/comments/declaration names and typeParameter for generic T, and the code-action handler merges import, diagnostic-fix, and optimize-imports providers.
Also correct codeAction/resolve's rationale: it is a no-op because actions attach their WorkspaceEdit eagerly (no round-trip needed), not because the action list is empty. Genuine remaining limitations (byte-vs-UTF-16 token length, interpolation granularity) are reworded, not removed.
Comment-only; no behavior change. Suite green (889 tests).