ci(release): tolerate the PHAR smoke-test timeout under errexit#7
Merged
Conversation
GitHub runs `run:` steps with `bash -eo pipefail`, so the bare `timeout 10s php var/xphp-lsp.phar </dev/null; status=$?` aborted the Smoke-test step the instant `timeout` returned 124 (server stayed up the full window) -- before the "124 is a healthy boot" guard could run -- failing the release with exit 124. Capture the exit code errexit-safely with `|| status=$?` so the guard is honoured; a real boot failure (any other non-zero, e.g. an autoload fatal) still fails the job as intended. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub runs
run:steps withbash -eo pipefail, so the baretimeout 10s php var/xphp-lsp.phar </dev/null; status=$?aborted the Smoke-test step the instanttimeoutreturned 124 (server stayed up the full window) -- before the "124 is a healthy boot" guard could run -- failing the release with exit 124.Capture the exit code errexit-safely with
|| status=$?so the guard is honoured; a real boot failure (any other non-zero, e.g. an autoload fatal) still fails the job as intended.