Integrator for curved and longitudinally dependent fields#797
Open
silkevdschueren wants to merge 19 commits into
Open
Integrator for curved and longitudinally dependent fields#797silkevdschueren wants to merge 19 commits into
silkevdschueren wants to merge 19 commits into
Conversation
…ial correction back and update tests
Contributor
|
Few additional steps for Leir and Polarizer Ring use case:
Additionally
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
New beam element
FieldExpansionto perform tracking through fields with longitudinal dependence and/or curvature based on a recursive representation (proceedings IPAC24) with a Runge-Kutta integrator. The practical implementation is a factory: when creating aFieldExpansioninstance, it spits out aBentFieldExpansionorStraightFieldExpansiondepending on curvature.Preliminary timing results (on my simple PC): tracking through a
FieldExpansionwith 100 steps takes 200us per particle per turn. Twissing a FODO cell made ofFieldExpansions takes similar times as a FODO cell made of regular Xsuite elements (difficult to quantify exactly due to compilation and cached twisses).Three dedicated tests are added to the PR. Full tests of xtrack have not yet been ran completely.
Important: there is a weird issue with the last test (test_twiss). When ran sequentially, it comes last and passes without problem. But when ran in parallel using xdist, that specific test fails the twiss with a ClosedOrbitSearchError....
Checklist
Mandatory:
Optional: