fix wrong statistics dump + clippy + gh action #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yonip23
commented
Dec 9, 2021
Comment on lines
-26
to
-27
| let mut calls = self.calls.clone(); | ||
| calls.sort(); |
Contributor
Author
There was a problem hiding this comment.
Problem was that I cloned the calls vec, sorted it, and then called self.calls.get(i) instead of just calls.get(i) (on the cloned vec).
I decided to fix it by removing the call for clone, changing the signature to receive a mutable reference to self and sort the calls vec in place (on self).
This way its more readable, less error prune and less memcps.
Wdyt?
yonip23
commented
Dec 9, 2021
Comment on lines
-12
to
+14
| enabled: Option<bool>, | ||
| _enabled: Option<bool>, | ||
| #[darling(default)] | ||
| main: Option<String>, | ||
| _main: Option<String>, |
Contributor
Author
There was a problem hiding this comment.
These 2 fields are never read according to clippy, I didn't want to delete them because it'll be a breaking change. Wdyt?
y2kappa
approved these changes
Dec 30, 2021
Owner
|
hey, can you bump the version and also publish the update please? |
Contributor
Author
|
i totally forgot about this pr lol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @y2kappa, its been a while! 😁
I'm using this crate in one of my other projects and noticed that the statistics dump wasn't calculated correctly, so I took a few minutes to fix this up (will explain the issue in comments)
I also noticed that there are clippy warnings hanging around for a while that for some reason didn't fail the CI! So I replaced the action with another one Im familiar with and know it works better, and fixed those clippy warnings.
Hope to get a review soon, thanks!