Skip to content

simplify the dependency management - #649

Open
Shfdis wants to merge 12 commits into
mainfrom
set-up-cpm-cpack
Open

simplify the dependency management#649
Shfdis wants to merge 12 commits into
mainfrom
set-up-cpm-cpack

Conversation

@Shfdis

@Shfdis Shfdis commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@Shfdis Shfdis added the SLO label Aug 5, 2026
@github-actions github-actions Bot removed the SLO label Aug 6, 2026
@Shfdis Shfdis added the SLO label Aug 6, 2026
@codecov

codecov Bot commented Aug 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.82%. Comparing base (3884161) to head (ddac262).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #649   +/-   ##
=======================================
  Coverage   50.82%   50.82%           
=======================================
  Files         266      266           
  Lines       30888    30888           
=======================================
  Hits        15700    15700           
  Misses      15188    15188           
Flag Coverage Δ
sdk 50.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions Bot removed the SLO label Aug 6, 2026
@Shfdis Shfdis added the SLO label Aug 6, 2026
@github-actions github-actions Bot removed the SLO label Aug 6, 2026
@Shfdis Shfdis added the SLO label Aug 7, 2026
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

🌋 SLO Test Results

🟢 2 workload(s) tested — All thresholds passed

Commit: fc57203 · View run

Workload Thresholds Duration Report
cpp-key-value-userver 🟢 OK 10m 6s 📄 Report
cpp-key-value 🟢 OK 10m 5s 📄 Report

Generated by ydb-slo-action

@github-actions github-actions Bot removed the SLO label Aug 7, 2026
@Shfdis

Shfdis commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

Reviewed commit: 411faf5cdb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread cmake/dependencies.cmake
Comment thread cmake/PackSDK.cmake
Comment thread cmake/dependencies.cmake
@robot-vibe-db

robot-vibe-db Bot commented Aug 10, 2026

Copy link
Copy Markdown

AI Review Summary

Verdict: ✅ No critical issues found

Critical issues

No critical issues found.

Other findings

  • Minor | Medium: CMAKE_POLICY_VERSION_MINIMUM 3.5 set as a CACHE STRING leaks to consumer projects via add_subdirectory(), potentially suppressing their deprecation warnings — cmake/dependencies.cmake:35
  • Minor | Medium: DEB package depends on libgtest-dev but GTest is not a transitive dependency of the installed SDK libraries; the matching find_package(GTest) was already removed from the config template — cmake/PackSDK.cmake:24
  • Nit | High: gRPC provider cache variables are redundantly specified both via set(... FORCE) and via CPMAddPackage OPTIONScmake/dependencies.cmake:234-266

Positive observations

The migration from git submodules + FetchContent to CPM is well-structured:

  • Centralized version manifest in cmake/dependencies.cmake with a clean dual-mode design (CPM vs SYSTEM)
  • _ydb_sdk_cpm_package_stub and _ydb_sdk_alias_library helpers correctly bridge CPM targets to the conventional names expected by downstream find_package() calls
  • The libprotoc include-directory workaround for gRPC 1.60 is properly scoped (save/modify/restore pattern)
  • Duplicate commit/author git calls fixed in generate_vcs_info.py; six dependency correctly replaced with Python 3 builtins
  • Duplicate --merge-lines flag removed from gcovr script
  • CI workflows, Dockerfiles, and SLO workloads are consistently updated to use CPM_SOURCE_CACHE and the simplified dependency install
  • The ydb-cpp-sdk-config.cmake.in correctly conditions the OpenTelemetry find_package on CPM mode only (in SYSTEM mode, otel sources are compiled into the static library)
  • README simplification accurately reflects the reduced prerequisites

This review was generated automatically. Critical issues require attention; other findings are advisory.
If this comment was useful, please give it a 👍 — it helps us improve the review bot.

@robot-vibe-db

robot-vibe-db Bot commented Aug 10, 2026

Copy link
Copy Markdown

Full analysis log

Analysis performed by claude, claude-opus-4-6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants