Skip to content

Conversation

@ydbot
Copy link
Collaborator

@ydbot ydbot commented Dec 6, 2025

Changelog entry

heap-use-after-free in a PQ tablet: Issue #30258

The BeginDeletePartitions method uses a value that can previously be deleted in TryDeleteWriteId.

Changelog category

  • Bugfix

Description for reviewers

Original PR(s)

Metadata

Git Cherry-Pick Log

=== Cherry-picking 25029c1 ===
Auto-merging ydb/core/persqueue/pqtablet/pq_impl.cpp
[cherry-pick-stable-25-3-1-251206-135057 9094b636d50] heap-use-after-free in a PQ tablet (#30257)
 Author: Alek5andr-Kotov <akotov@ydb.tech>
 Date: Sat Dec 6 14:23:11 2025 +0300
 1 file changed, 2 insertions(+), 1 deletion(-)

PR was created by cherry-pick workflow run

@ydbot ydbot requested a review from a team as a code owner December 6, 2025 13:51
@ydbot ydbot enabled auto-merge December 6, 2025 13:51
@github-actions
Copy link

github-actions bot commented Dec 6, 2025

🟢 2025-12-06 13:54:18 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Dec 6, 2025

2025-12-06 13:55:04 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5fe4069 has started.
2025-12-06 13:55:20 UTC Artifacts will be uploaded here
2025-12-06 13:58:51 UTC ya make is running...
🟡 2025-12-06 15:26:18 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30742 29420 0 4 1301 17

2025-12-06 15:28:39 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-12-06 15:44:57 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
578 (only retried tests) 564 0 1 1 12

2025-12-06 15:45:07 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-12-06 15:59:11 UTC Tests successful.

Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
532 (only retried tests) 520 0 0 0 12

🟢 2025-12-06 15:59:19 UTC Build successful.
🟢 2025-12-06 15:59:39 UTC ydbd size 2.3 GiB changed* by -64 Bytes, which is <= 0 Bytes vs stable-25-3-1: OK

ydbd size dash stable-25-3-1: b827c92 merge: 5fe4069 diff diff %
ydbd size 2 437 103 384 Bytes 2 437 103 320 Bytes -64 Bytes -0.000%
ydbd stripped size 521 877 928 Bytes 521 877 864 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Dec 6, 2025

2025-12-06 13:56:23 UTC Pre-commit check linux-x86_64-release-asan for 5fe4069 has started.
2025-12-06 13:56:38 UTC Artifacts will be uploaded here
2025-12-06 14:00:13 UTC ya make is running...
🟡 2025-12-06 16:09:48 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15421 14929 0 180 295 17

🟢 2025-12-06 16:10:59 UTC Build successful.
🟢 2025-12-06 16:11:30 UTC ydbd size 3.8 GiB changed* by -304 Bytes, which is <= 0 Bytes vs stable-25-3-1: OK

ydbd size dash stable-25-3-1: b827c92 merge: 5fe4069 diff diff %
ydbd size 4 055 129 096 Bytes 4 055 128 792 Bytes -304 Bytes -0.000%
ydbd stripped size 1 511 174 848 Bytes 1 511 174 656 Bytes -192 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ydbot ydbot merged commit 20ebf5c into stable-25-3-1 Dec 6, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants