fix: improve accessibility in FilterSearch and Facets (v2.2.0)#638
Merged
fix: improve accessibility in FilterSearch and Facets (v2.2.0)#638
Conversation
k-gerner
changed the title
Fondryext
previously approved these changes
Mar 5, 2026
Contributor
|
May be worth quickly double-checking coverage failures, even if likely unrelated to the change itself |
* suppress error/warning spam, fix key errors etc * set ts output dir to dist * retry logic to WCAG
Contributor
|
Current unit coverage is 88.89799262597296% |
Fondryext
previously approved these changes
Mar 6, 2026
…ons; update locales
k-gerner
changed the title
k-gerner
changed the title
k-gerner
changed the title
anguyen-yext2
approved these changes
Mar 9, 2026
k-gerner
added a commit
that referenced
this pull request
Mar 9, 2026
* feat: allow users to turn analytics on and off (v2.1.0) (#632) * feat: allow users to turn analytics on and off (v2.1.0) This PR adds a new property to the SearchAnalyticsConfig, which can be used to start with analytics enabled or disabled by default. Three new methods are added to the analytics object- two to turn analytics on/off, and one to get the current enabled status. J=WAT-5404 TEST=auto, manual Ran test site locally with debugging and buttons to turn analytics on and off, saw expected behavior. * Update various names to be in-line with pages code * Automated update to repo's documentation from github action * Add enableYextAnalytics function to window * drop unneeded parens --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * release: v2.1.0 * More accessbilities fixes for autocomplete results (#635) * More accessbilities fixes for autocomplete results Associate the visible label with the input via `label` + `htmlFor`, and wire `DropdownInput` with `inputId` and `aria-labelledby`. Change the instructions container from `hidden` to `sr-only`, so `aria-describedby` references content that is actually exposed to screen readers. J=WAT-5357 TEST=manual tested with voice over enabled on test-site * Update snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * release: v2.1.1 * chore: suppress error/warning spam, fix key errors etc (#642) * fix: point TypeScript output to dist directory (#644) * suppress error/warning spam, fix key errors etc * set ts output dir to dist * retry logic to WCAG * release: v2.1.2 * fix: improve accessibility in FilterSearch and Facets (v2.2.0) (#638) * fix linting; added optional region landmark semantics to FilterSearch * Automated update to repo's documentation from github action * chore: suppress error/warning spam, fix key errors etc (#642) * fix: point TypeScript output to dist directory (#644) * suppress error/warning spam, fix key errors etc * set ts output dir to dist * retry logic to WCAG * release: v2.1.2 * revert fieldset legend accessibility change * Automated update to repo's documentation from github action * optional toggle to show label on facet/static filter searchable sections; update locales * add group section semantics to filter search results when multiple sections --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: Fondryext <160865254+Fondryext@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jacob Fondriest <jfondriest@yext.com> Co-authored-by: anguyen-yext2 <143001514+anguyen-yext2@users.noreply.github.com> Co-authored-by: anguyen-yext2 <anguyen@yext.com> Co-authored-by: Kyle Gerner <49618240+k-gerner@users.noreply.github.com> Co-authored-by: Kyle Gerner <kgerner@yext.com>
k-gerner
added a commit
that referenced
this pull request
Mar 9, 2026
* feat: allow users to turn analytics on and off (v2.1.0) (#632) * feat: allow users to turn analytics on and off (v2.1.0) This PR adds a new property to the SearchAnalyticsConfig, which can be used to start with analytics enabled or disabled by default. Three new methods are added to the analytics object- two to turn analytics on/off, and one to get the current enabled status. J=WAT-5404 TEST=auto, manual Ran test site locally with debugging and buttons to turn analytics on and off, saw expected behavior. * Update various names to be in-line with pages code * Automated update to repo's documentation from github action * Add enableYextAnalytics function to window * drop unneeded parens --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * release: v2.1.0 * More accessbilities fixes for autocomplete results (#635) * More accessbilities fixes for autocomplete results Associate the visible label with the input via `label` + `htmlFor`, and wire `DropdownInput` with `inputId` and `aria-labelledby`. Change the instructions container from `hidden` to `sr-only`, so `aria-describedby` references content that is actually exposed to screen readers. J=WAT-5357 TEST=manual tested with voice over enabled on test-site * Update snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * release: v2.1.1 * chore: suppress error/warning spam, fix key errors etc (#642) * fix: point TypeScript output to dist directory (#644) * suppress error/warning spam, fix key errors etc * set ts output dir to dist * retry logic to WCAG * release: v2.1.2 * fix: improve accessibility in FilterSearch and Facets (v2.2.0) (#638) * fix linting; added optional region landmark semantics to FilterSearch * Automated update to repo's documentation from github action * chore: suppress error/warning spam, fix key errors etc (#642) * fix: point TypeScript output to dist directory (#644) * suppress error/warning spam, fix key errors etc * set ts output dir to dist * retry logic to WCAG * release: v2.1.2 * revert fieldset legend accessibility change * Automated update to repo's documentation from github action * optional toggle to show label on facet/static filter searchable sections; update locales * add group section semantics to filter search results when multiple sections --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * hotfix: improve accessibility in FilterSearch (v2.2.0) (#649) - make sure autocomplete option count is announced when the input is cleared too - detect all stale state value usages when using React.useState and fix to use a functional state update (eg setValue(value + 1) becomes setValue(prev => prev + 1)) * chore: update svgo and storybook (#651) * release: v2.2.0 --------- Co-authored-by: Fondryext <160865254+Fondryext@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jacob Fondriest <jfondriest@yext.com> Co-authored-by: anguyen-yext2 <143001514+anguyen-yext2@users.noreply.github.com> Co-authored-by: anguyen-yext2 <anguyen@yext.com> Co-authored-by: Kyle Gerner <49618240+k-gerner@users.noreply.github.com> Co-authored-by: Kyle Gerner <kgerner@yext.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
FilterSearchFilterSearchcontainer now conditionally getsrole="region"andaria-labelwhen a region label is available, set viaresultsRegionAriaLabelpropshowOptionsSearchInputLabelprop toStandardFacetPropsandStaticFiltersProps, which is disabled by default. When set totrue, the search bar (when present) for these components will have an additional label, of the form"Search {{title}} Options".role="group"and respectivearia-labeledbyattribute to filter search dropdown results when the results are sectionedJ=WAT-5415
TEST=auto