Skip to content

fix: locator result card address format#1067

Merged
benlife5 merged 3 commits intomainfrom
locator-address-fmt
Feb 26, 2026
Merged

fix: locator result card address format#1067
benlife5 merged 3 commits intomainfrom
locator-address-fmt

Conversation

@benlife5
Copy link
Contributor

We recently changed all other addresses to use the default pages-components address formatting since it has built-in regionalization support

https://yext.slack.com/archives/C02UVSE7P6W/p1772118800515789

@github-actions
Copy link
Contributor

Warning: Component files have been updated but no migrations have been added. See https://github.com/yext/visual-editor/blob/main/packages/visual-editor/src/components/migrations/README.md for more information.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dec9f1c and a6d73af.

📒 Files selected for processing (1)
  • packages/visual-editor/src/components/LocatorResultCard.tsx

Walkthrough

The LocatorResultCard component was refactored to simplify how the Address component is rendered. Previously, individual address properties (line1, line2, city/region/postalCode) were explicitly constructed and passed to the Address component. The change consolidates this to pass a single address property instead, reducing code complexity and altering the address formatting output.

Possibly related PRs

Suggested reviewers

  • mkilpatrick
  • briantstephan
  • jwartofsky-yext
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating the address format in the locator result card component to use default formatting with regionalization support.
Description check ✅ Passed The description clearly explains the change's purpose: aligning locator result card address formatting with other addresses in the codebase for consistency and built-in regionalization support.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch locator-address-fmt

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

asanehisa
asanehisa previously approved these changes Feb 26, 2026
@benlife5 benlife5 merged commit 1cf28b2 into main Feb 26, 2026
17 checks passed
@benlife5 benlife5 deleted the locator-address-fmt branch February 26, 2026 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants