add safe check for Executor and Tx evaluation#14
Merged
yihuang merged 10 commits intoyihuang:mainfrom Mar 24, 2026
Merged
Conversation
refactor Executor transitions to compute reads/validation locally
no need after fix in will62794/spectacle#84
This reverts commit c0e2efe.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the TLA+ specs to be more robust during evaluation/visualization by adding a guard to avoid problematic ranges in FindMem, and tweaks module instantiation and README visualization links.
Changes:
- Add an explicit base-case guard in
Mem!FindMemfortxn <= 1. - Update
Tx’sINSTANCE Memsubstitutions (now explicitly mappingStorageandmem). - Update README “live visualization” links to use a different Spectacle host.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Tx.tla | Adjusts INSTANCE Mem substitutions (explicitly maps Storage and mem). |
| Mem.tla | Adds a guard in FindMem to return 0 for txn <= 1. |
| README.md | Updates Spectacle visualization links to a new host. |
yihuang
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.