Add "Open source workfile" loader action#128
Draft
BigRoy wants to merge 6 commits intoynput:developfrom
Draft
Conversation
… from the standalone browser
… word 'traypublisher' Similarly - error accordingly if the source filepath does not exist
BigRoy
commented
Jan 28, 2026
| preferred_index = i | ||
| label += " (used to create publish)" | ||
|
|
||
| # TODO: Show application icon if available |
Contributor
Author
There was a problem hiding this comment.
We may want to use a dedicated re-usable dialog here? Something matching the choose app logic in terminal launch code.
iLLiCiTiT
reviewed
Jan 29, 2026
|
|
||
| return compatible | ||
|
|
||
| def _show_app_dialog( |
Member
There was a problem hiding this comment.
I would say that this should not use Qt at all, but ActionForm instead.
iLLiCiTiT
reviewed
Jan 29, 2026
Comment on lines
+46
to
+47
| if version.get("attrib", {}).get("source"): | ||
| return True |
Member
There was a problem hiding this comment.
I think that all hosts do fill source, but it does not have to be workfile (e.g. traypublisher).
Suggested change
| if version.get("attrib", {}).get("source"): | |
| return True | |
| source = version.get("attrib", {}).get("source") | |
| if source and source.starswith("{root"): | |
| return True |
Contributor
Author
There was a problem hiding this comment.
I've seen some being other values indeed - like source image sequences with %d in the source path, and also just the word traypublisher. I'll think for a bit whether I like the {root requirement - it does make sense for the cases we do kind of know what it should be like.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
Add action to open source workfile that created the publish, directly from the standalone browser
Additional review information
is it me or should the cancel and open buttons be swapped around?
This may solve ticket YN-0365 and could act as a usable fix for ynput/ayon-core#1635 even though it's not exactly the same.
Quite a few TODOs in the code to discuss stilll, hence draft for now - yet still good to discuss overall approach.
Fix #137
Testing notes: