Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
martastain
reviewed
Mar 16, 2026
…mplicit (fall through) returns' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
…on-backend into feature/data_imports
Row identification needs to be reworked
martastain
requested changes
Apr 22, 2026
| from ayon_server.settings.anatomy.templates import Templates | ||
| from ayon_server.settings.common import BaseSettingsModel | ||
| from ayon_server.settings.settings_field import SettingsField | ||
| from ayon_server.settings.validators import ensure_unique_names |
Member
There was a problem hiding this comment.
I am not sure this is a good idea: I believe ensure_unique_names is a validator already used in addons. ensure_unique_property is fine, but we need to keep the original as well (that would under the hood just call ensure_unique_property)
|
|
||
|
|
||
| @router.post("/import/{import_type}") | ||
| async def import_data( |
Member
There was a problem hiding this comment.
Not critical, but I'd prefer using Annotated with explicit Query field to denote that the parameter comes from the query parameter - it also allows you to add regex validators for string fields easily.
Member
Author
There was a problem hiding this comment.
Didnt understand. What should be Annotated?
ValueError is supposed to be 'internal' exception, BadRequestException shouldn't be polluting logs.
| return value | ||
|
|
||
| @validator("folder_types", "task_types", "statuses") | ||
| def ensure_unique_short_names(cls, value, field): |
Moved to common.py
martastain
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains functionality for export and imports of various entities into CSV files.
Currently implemented:
It supports selection of exportable fields, behavior of imports (fail, skip errors) etc.
Technical details
Moved out of ayon-power-pack https://github.com/ynput/ayon-power-pack/pull/58 as it should be part of server backend.
Additional context