Extract Review: Substance Painter reviewables do not integrate

[BigRoy]

Changelog Description

With #1526 we got reviewables for substance painter textures, but they also got integrated as representations, like png_png.

Additional info

With these changes it should only make the reviewable upload.

See ayon chat conversation; https://discord.com/channels/517362899170230292/563751989075378201/1447931139263168553

Community and @LiborBatek says that these are working settings:

https://discord.com/channels/517362899170230292/1447896320101580851/1447972537060298902

Testing notes:

1. Reviewables should be uploaded, but no extra representation should be integrated.

[moonyuet]

Looks good for me

[LiborBatek]

As I have tested this does not work...when using tags delete and need_thumbnail which results into not having any sort of reviewable but just thumbnail...

so I guess this combo of tags is not working for having reviewable and must be adjusted.

On positive side of things, yes there is no additional repre integrated tho...

There must be probably different tag used other than need_thumbnail

[BigRoy]

@jakubjezek001 @iLLiCiTiT do you happen to know what the right combination would be here?

This is the preferred outcome:

1. Do not integrate the image as representation.
2. Generate a thumbnail.
3. Add as reviewable.

[iLLiCiTiT]

I guess this deservers an issue. Right now there is a lot of compatibilities and checks that are out of date, or out of use-cases. We could go through all of that and change the thumbnail creation behavior.

[LiborBatek]

Seems like that the settings from the testing steps does not produce desired result neither,

I have tried multiple publishes with different publish plugin Extract Review settings but I was not able to achieve both having Reviewable media and not additional representation.

I have tried to distiguish the representation by changing it from PNG to JPEG and see how that works together with using DELETE flag and not.

It resulted into no reviewable and no additional representation tho. When removing that DELETE flag it start to integrate the reviewable again but with additional representation too.

as seen below

here are my publish Extract Review plugin settings:

Also adding my publish JSON report:

SPainter-publish-report-260217-14-52.json.txt

[iLLiCiTiT]

here are my publish Extract Review plugin settings:

Aren't those wrong? You have to add "delete" and "need_thumbnail" to tags. Please reset the settings to use defaults, when you upload the addon, to actually test this PR changes.

[LiborBatek]

I had reset my ayon-core settings for any category (extract review, transcode etc) and here are the results:

No reviewable just thumbnail:

Resulting files:

Im also enclosing the Publish JSON report for you:

SP-publish-report-260226-11-13.json.txt