Skip to content

Extract Review: Set Review Layer Priority#1729

Merged
moonyuet merged 62 commits intodevelopfrom
feature/YN-0277--Extract-Review--Set-review-layer-name-priorities
Apr 22, 2026
Merged

Extract Review: Set Review Layer Priority#1729
moonyuet merged 62 commits intodevelopfrom
feature/YN-0277--Extract-Review--Set-review-layer-name-priorities

Conversation

@moonyuet
Copy link
Copy Markdown
Member

@moonyuet moonyuet commented Mar 2, 2026

Changelog Description

This PR is to add options to allow users setting review layer priority for Extract Review
Resolve: #1581

Additional info

Haven't tested and figured out the best way to sort the review layer priority

Testing notes:

  1. Create Render
  2. Publish

@moonyuet moonyuet requested a review from BigRoy March 2, 2026 05:45
@moonyuet moonyuet self-assigned this Mar 2, 2026
@moonyuet moonyuet added type: feature Adding something new and exciting to the product sponsored This is directly sponsored by a client or community member labels Mar 2, 2026
@ynbot ynbot added the size/XS label Mar 2, 2026
@moonyuet moonyuet requested a review from LiborBatek March 2, 2026 05:47
Comment thread client/ayon_core/plugins/publish/extract_review.py Outdated
@ynbot ynbot moved this to Review In Progress in PR reviewing Mar 2, 2026
Comment thread client/ayon_core/lib/transcoding.py Outdated
Comment thread client/ayon_core/lib/transcoding.py Outdated
@moonyuet moonyuet requested a review from BigRoy March 2, 2026 10:30
@moonyuet
Copy link
Copy Markdown
Member Author

moonyuet commented Mar 2, 2026

@BigRoy I committed some changes regarding to the convo above. But the changes are definitely affecting multiple functions so maybe it would be helpful you can take a look before all the testings. (I guess we need to test across different hosts?)

Comment thread tests/client/ayon_core/lib/test_transcoding.py Outdated
@moonyuet moonyuet requested a review from BigRoy March 2, 2026 13:54
Copy link
Copy Markdown
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some early comments, it also looks like you haven't updated all relevant places, e.g. ExtractOIIOTranscode also runs oiio_color_convert which runs get_oiio_input_and_channel_args which also tries to find the 'reviewable channel'.

My gut feeling says that we should have just one place where you specify the actual reviewable channels to use - but perhaps, the way you're doing it now where each plug-in can define its own makes it way more customizable and granular (but also more work to consistently configure)

Comment thread client/ayon_core/lib/transcoding.py Outdated
Comment thread client/ayon_core/lib/transcoding.py Outdated
Comment thread client/ayon_core/lib/transcoding.py Outdated
Comment thread client/ayon_core/lib/transcoding.py Outdated
@moonyuet moonyuet force-pushed the feature/YN-0277--Extract-Review--Set-review-layer-name-priorities branch from 9cad1b5 to 49fb6b7 Compare March 3, 2026 14:18
@moonyuet moonyuet requested a review from BigRoy March 3, 2026 14:36
Copy link
Copy Markdown
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to pass on just review_layers instead of full project_settings to the calls in transcoding api?

Comment thread client/ayon_core/lib/transcoding.py Outdated
Comment thread client/ayon_core/lib/transcoding.py Outdated
Comment thread client/ayon_core/lib/transcoding.py Outdated
Comment thread client/ayon_core/lib/transcoding.py Outdated
Comment thread client/ayon_core/lib/transcoding.py Outdated
Comment thread client/ayon_core/lib/transcoding.py Outdated
Comment thread client/ayon_core/lib/transcoding.py Outdated
Comment thread client/ayon_core/plugins/publish/extract_color_transcode.py
@moonyuet moonyuet requested a review from BigRoy March 4, 2026 08:46
Copy link
Copy Markdown
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this seems be going to something that may work, I have a few small notes - and then maybe it's time to actually give this some actual testing instead of code review.

@iLLiCiTiT can you do a quick pass on the code? We're penetrating review_layers now all the way to the call where we need it. It's the most granular approach where it can be customized in different ways down the line if needed. But I'm sure you have something to say in general and would love to know what you think.

@moonyuet did you do a test run yourself? if it does work in at least a test run on your end, I think we can take this out of "Draft" so that we review it accordingly

Comment thread client/ayon_core/lib/transcoding.py Outdated
Comment thread tests/client/ayon_core/lib/test_transcoding.py Outdated
Comment thread server/settings/main.py Outdated
moonyuet added 2 commits March 4, 2026 20:24
…ture/YN-0277--Extract-Review--Set-review-layer-name-priorities
Comment thread client/ayon_core/plugins/publish/extract_burnin.py Outdated
Comment thread client/ayon_core/plugins/publish/extract_review.py Outdated
Comment thread client/ayon_core/plugins/publish/extract_review.py Outdated
moonyuet and others added 11 commits April 21, 2026 22:45
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
@moonyuet moonyuet requested a review from iLLiCiTiT April 21, 2026 15:06
@moonyuet
Copy link
Copy Markdown
Member Author

@iLLiCiTiT can you check again?

Copy link
Copy Markdown
Member

@iLLiCiTiT iLLiCiTiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes do look ok, but I don't know if the logic is ok, and if it works. Needs @BigRoy to verify and probably @LiborBatek to test.

@github-project-automation github-project-automation Bot moved this from Review In Progress to Merge Requested in PR reviewing Apr 21, 2026
@LiborBatek LiborBatek self-requested a review April 22, 2026 09:29
Copy link
Copy Markdown
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im getting an errors while DL publish job been processed

 ERROR:pyblish.plugin:Traceback (most recent call last):
2026-04-22 11:27:08:  0: STDOUT:   File "C:\Users\lbate\AppData\Local\Ynput\AYON\dependency_packages\ayon_2510271030_windows.zip\dependencies\pyblish\plugin.py", line 528, in __explicit_process
2026-04-22 11:27:08:  0: STDOUT:     runner(*args)
2026-04-22 11:27:08:  0: STDOUT:   File "C:\Users\lbate\AppData\Local\Ynput\AYON\addons\core_1.9.0+dev\ayon_core\plugins\publish\extract_thumbnail.py", line 121, in process
2026-04-22 11:27:08:  0: STDOUT:     self._main_process(instance)
2026-04-22 11:27:08:  0: STDOUT:   File "C:\Users\lbate\AppData\Local\Ynput\AYON\addons\core_1.9.0+dev\ayon_core\plugins\publish\extract_thumbnail.py", line 267, in _main_process
2026-04-22 11:27:08:  0: STDOUT:     repre_thumb_created = self._create_colorspace_thumbnail(
2026-04-22 11:27:08:  0: STDOUT:   File "C:\Users\lbate\AppData\Local\Ynput\AYON\addons\core_1.9.0+dev\ayon_core\plugins\publish\extract_thumbnail.py", line 478, in _create_colorspace_thumbnail
2026-04-22 11:27:08:  0: STDOUT:     resolution_arg = self._get_resolution_args(
2026-04-22 11:27:08:  0: STDOUT: TypeError: _get_resolution_args() missing 1 required positional argument: 'review_layers'
2026-04-22 11:27:08:  0: STDOUT: Traceback (most recent call last):
2026-04-22 11:27:08:  0: STDOUT:   File "C:\Users\lbate\AppData\Local\Ynput\AYON\dependency_packages\ayon_2510271030_windows.zip\dependencies\pyblish\plugin.py", line 528, in __explicit_process
2026-04-22 11:27:08:  0: STDOUT:     runner(*args)
2026-04-22 11:27:08:  0: STDOUT:   File "C:\Users\lbate\AppData\Local\Ynput\AYON\addons\core_1.9.0+dev\ayon_core\plugins\publish\extract_thumbnail.py", line 121, in process
2026-04-22 11:27:08:  0: STDOUT:     self._main_process(instance)
2026-04-22 11:27:08:  0: STDOUT:   File "C:\Users\lbate\AppData\Local\Ynput\AYON\addons\core_1.9.0+dev\ayon_core\plugins\publish\extract_thumbnail.py", line 267, in _main_process
2026-04-22 11:27:08:  0: STDOUT:     repre_thumb_created = self._create_colorspace_thumbnail(
2026-04-22 11:27:08:  0: STDOUT:   File "C:\Users\lbate\AppData\Local\Ynput\AYON\addons\core_1.9.0+dev\ayon_core\plugins\publish\extract_thumbnail.py", line 478, in _create_colorspace_thumbnail
2026-04-22 11:27:08:  0: STDOUT:     resolution_arg = self._get_resolution_args(
2026-04-22 11:27:08:  0: STDOUT: TypeError: _get_resolution_args() missing 1 required positional argument: 'review_layers'
2026-04-22 11:27:08:  0: STDOUT: !!! ERR: 2026-04-22 11:27:08,498 >>> { CLI-publish }: [ Failed ExtractThumbnail: _get_resolution_args() missing 1 required positional argument: 'review_layers' -- <FrameSummary file C:\Users\lbate\AppData\Local\Ynput\AYON\addons\core_1.9.0+dev\ayon_core\plugins\publish\extract_thumbnail.py, line 478 in _create_colorspace_thumbnail> ] 
2026-04-22 11:27:08:  0: STDOUT: --- your system is set to use custom CA certificate bundle.

Here is my scene setup for multilayer EXR with some AOVs added so the Beauty not been the first one... using AO and Composite among other aovs..

Image

Also rather enclosing the full DL job log with errors...

DL-PublishJob_2026-04-22_11-27-12_69e89470e3519c9ef3743267.txt

@github-project-automation github-project-automation Bot moved this from Merge Requested to Change Requested in PR reviewing Apr 22, 2026
@moonyuet moonyuet requested a review from LiborBatek April 22, 2026 09:39
Copy link
Copy Markdown
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now its working well...no failures.

Been tested with blender 5.1 and also maya 2026

LGTM

@github-project-automation github-project-automation Bot moved this from Change Requested to Merge Requested in PR reviewing Apr 22, 2026
@moonyuet moonyuet merged commit d2e1759 into develop Apr 22, 2026
4 checks passed
@moonyuet moonyuet deleted the feature/YN-0277--Extract-Review--Set-review-layer-name-priorities branch April 22, 2026 17:03
@github-project-automation github-project-automation Bot moved this from Merge Requested to Done in PR reviewing Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS sponsored This is directly sponsored by a client or community member type: feature Adding something new and exciting to the product

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

YN-0277: Extract Review: Set review layer name priorities

6 participants