Extract Review: Set Review Layer Priority#1729
Conversation
|
@BigRoy I committed some changes regarding to the convo above. But the changes are definitely affecting multiple functions so maybe it would be helpful you can take a look before all the testings. (I guess we need to test across different hosts?) |
BigRoy
left a comment
There was a problem hiding this comment.
Some early comments, it also looks like you haven't updated all relevant places, e.g. ExtractOIIOTranscode also runs oiio_color_convert which runs get_oiio_input_and_channel_args which also tries to find the 'reviewable channel'.
My gut feeling says that we should have just one place where you specify the actual reviewable channels to use - but perhaps, the way you're doing it now where each plug-in can define its own makes it way more customizable and granular (but also more work to consistently configure)
…ate settings in ayon core
9cad1b5 to
49fb6b7
Compare
BigRoy
left a comment
There was a problem hiding this comment.
Make sure to pass on just review_layers instead of full project_settings to the calls in transcoding api?
There was a problem hiding this comment.
Overall this seems be going to something that may work, I have a few small notes - and then maybe it's time to actually give this some actual testing instead of code review.
@iLLiCiTiT can you do a quick pass on the code? We're penetrating review_layers now all the way to the call where we need it. It's the most granular approach where it can be customized in different ways down the line if needed. But I'm sure you have something to say in general and would love to know what you think.
@moonyuet did you do a test run yourself? if it does work in at least a test run on your end, I think we can take this out of "Draft" so that we review it accordingly
…ture/YN-0277--Extract-Review--Set-review-layer-name-priorities
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
|
@iLLiCiTiT can you check again? |
iLLiCiTiT
left a comment
There was a problem hiding this comment.
Code changes do look ok, but I don't know if the logic is ok, and if it works. Needs @BigRoy to verify and probably @LiborBatek to test.
LiborBatek
left a comment
There was a problem hiding this comment.
Im getting an errors while DL publish job been processed
ERROR:pyblish.plugin:Traceback (most recent call last):
2026-04-22 11:27:08: 0: STDOUT: File "C:\Users\lbate\AppData\Local\Ynput\AYON\dependency_packages\ayon_2510271030_windows.zip\dependencies\pyblish\plugin.py", line 528, in __explicit_process
2026-04-22 11:27:08: 0: STDOUT: runner(*args)
2026-04-22 11:27:08: 0: STDOUT: File "C:\Users\lbate\AppData\Local\Ynput\AYON\addons\core_1.9.0+dev\ayon_core\plugins\publish\extract_thumbnail.py", line 121, in process
2026-04-22 11:27:08: 0: STDOUT: self._main_process(instance)
2026-04-22 11:27:08: 0: STDOUT: File "C:\Users\lbate\AppData\Local\Ynput\AYON\addons\core_1.9.0+dev\ayon_core\plugins\publish\extract_thumbnail.py", line 267, in _main_process
2026-04-22 11:27:08: 0: STDOUT: repre_thumb_created = self._create_colorspace_thumbnail(
2026-04-22 11:27:08: 0: STDOUT: File "C:\Users\lbate\AppData\Local\Ynput\AYON\addons\core_1.9.0+dev\ayon_core\plugins\publish\extract_thumbnail.py", line 478, in _create_colorspace_thumbnail
2026-04-22 11:27:08: 0: STDOUT: resolution_arg = self._get_resolution_args(
2026-04-22 11:27:08: 0: STDOUT: TypeError: _get_resolution_args() missing 1 required positional argument: 'review_layers'
2026-04-22 11:27:08: 0: STDOUT: Traceback (most recent call last):
2026-04-22 11:27:08: 0: STDOUT: File "C:\Users\lbate\AppData\Local\Ynput\AYON\dependency_packages\ayon_2510271030_windows.zip\dependencies\pyblish\plugin.py", line 528, in __explicit_process
2026-04-22 11:27:08: 0: STDOUT: runner(*args)
2026-04-22 11:27:08: 0: STDOUT: File "C:\Users\lbate\AppData\Local\Ynput\AYON\addons\core_1.9.0+dev\ayon_core\plugins\publish\extract_thumbnail.py", line 121, in process
2026-04-22 11:27:08: 0: STDOUT: self._main_process(instance)
2026-04-22 11:27:08: 0: STDOUT: File "C:\Users\lbate\AppData\Local\Ynput\AYON\addons\core_1.9.0+dev\ayon_core\plugins\publish\extract_thumbnail.py", line 267, in _main_process
2026-04-22 11:27:08: 0: STDOUT: repre_thumb_created = self._create_colorspace_thumbnail(
2026-04-22 11:27:08: 0: STDOUT: File "C:\Users\lbate\AppData\Local\Ynput\AYON\addons\core_1.9.0+dev\ayon_core\plugins\publish\extract_thumbnail.py", line 478, in _create_colorspace_thumbnail
2026-04-22 11:27:08: 0: STDOUT: resolution_arg = self._get_resolution_args(
2026-04-22 11:27:08: 0: STDOUT: TypeError: _get_resolution_args() missing 1 required positional argument: 'review_layers'
2026-04-22 11:27:08: 0: STDOUT: !!! ERR: 2026-04-22 11:27:08,498 >>> { CLI-publish }: [ Failed ExtractThumbnail: _get_resolution_args() missing 1 required positional argument: 'review_layers' -- <FrameSummary file C:\Users\lbate\AppData\Local\Ynput\AYON\addons\core_1.9.0+dev\ayon_core\plugins\publish\extract_thumbnail.py, line 478 in _create_colorspace_thumbnail> ]
2026-04-22 11:27:08: 0: STDOUT: --- your system is set to use custom CA certificate bundle.
Here is my scene setup for multilayer EXR with some AOVs added so the Beauty not been the first one... using AO and Composite among other aovs..
Also rather enclosing the full DL job log with errors...
DL-PublishJob_2026-04-22_11-27-12_69e89470e3519c9ef3743267.txt
…ew-layer-name-priorities
…priorities' of https://github.com/ynput/ayon-core into feature/YN-0277--Extract-Review--Set-review-layer-name-priorities
LiborBatek
left a comment
There was a problem hiding this comment.
Now its working well...no failures.
Been tested with blender 5.1 and also maya 2026
LGTM
Changelog Description
This PR is to add options to allow users setting review layer priority for Extract Review
Resolve: #1581
Additional info
Haven't tested and figured out the best way to sort the review layer priority
Testing notes: