Support using git addon version in makefile manage

[MustafaJafar]

Changelog Description

An alternative to #94

This PR adds support for AYON_USE_GIT_SUFFIX_FOR_ADDONS env var for initializing the processor services with addon version with the +git suffix. This is the same env var used on the ayon-docker server.

AYON_SERVER_URL=http://localhost:5000/
AYON_API_KEY=veryinsecureapikey
AYON_USE_GIT_SUFFIX_FOR_ADDONS=True

Additional details

when working with kitsu addon development, it's possible to develop from within the ayon-docker directly or from a separate directory.

Although, developing from within the ayon-docker/addons directly, if someone does, running servies live from source code won't work becasue the service is not initialized to work with the +git vesion. so, it fails to fetch settings.

I think such a solution can be adapted in other addons with services.

Testing notes:

1. when setting AYON_USE_GIT_SUFFIX_FOR_ADDONS to true it should set the addon version to +git.
2. when no setting it or setting it to false, the actual addon version should be used.

[iLLiCiTiT]

Not sure why to re-run the code and re-assign the variable

Suggested change

	if ($env:AYON_USE_GIT_SUFFIX_FOR_ADDONS -eq "True") {
	$AYON_ADDON_VERSION = Invoke-Expression -Command "python -c ""print('$($AYON_ADDON_VERSION)'.split('-')[0].split('+')[0] + '+git')"""
	}
	# Running Kitsu processor service script live requires the following environment variables to be set.
	$env:AYON_ADDON_NAME = $AYON_ADDON_NAME
	$env:AYON_ADDON_VERSION = $AYON_ADDON_VERSION
	$addon_version = $AYON_ADDON_VERSION
	if ($env:AYON_USE_GIT_SUFFIX_FOR_ADDONS -eq "True") {
	$addon_version = "($AYON_ADDON_VERSION)+git"
	}
	# Running Kitsu processor service script live requires the following environment variables to be set.
	$env:AYON_ADDON_NAME = $AYON_ADDON_NAME
	$env:AYON_ADDON_VERSION = $addon_version

BTW we usually set AYON_ADDON_NAME and AYON_ADDON_VERSION ahead so you can define different version from .env file (which I think is what you should do to add the +git TBH).

[iLLiCiTiT]

e.g. in ftrack it is set before any command is started, so e.g. RunDocker can also use custom version from .env file if needed.

[MustafaJafar]

I don't think this one works.

$addon_version = "($AYON_ADDON_VERSION)+git"

because addon version according to the this line

ayon-kitsu/services/processor/manage.ps1

Line 11 in c8ecc3c

$AYON_ADDON_VERSION = Invoke-Expression -Command "python -c ""import os;import sys;content={};f=open(r'$($script_dir)/../../package.py');exec(f.read(),content);f.close();print(content['version'])"""

will be 1.2.6+dev and AYON expects the name to be 1.2.6+git not 1.2.6+dev+git

[MustafaJafar]

e.g. in ftrack it is set before any command is started, so e.g. RunDocker can also use custom version from .env file if needed.

I see.
https://github.com/ynput/ayon-ftrack/blob/276e4c957c0920329355f794c92903b5b8a80aa7/service_tools/manage.ps1#L89-L91

Which function I should move this piece of code to?

• main
• RunDocker
• RunService

[iLLiCiTiT]

As far as I see, both main.sh and manage.ps1 are already reading .env file, so set AYON_ADDON_VERSION env only if is not set yet after load-env (include .env).