🏛️Product base types: Product types and base types by iLLiCiTiT · Pull Request #83 · ynput/ayon-resolve

iLLiCiTiT · 2026-03-05T15:44:54Z

Changelog Description

Use product base types and add support for product types used as aliases.

Additional review information

Codebase of Resolve addon is fully using product base type as "pipeline" type and product type as an alias. Load plugins define product_base_types for filtering, create plugins do define product_base_type and the whole logic is expecting that product base type is being used in the system.

Shot create plugin have option to define custom product types for plate and audio instances.

Side changes:

Moved override of apply_settings to the only create plugin which actually uses it.
Removed some backwards compatibily (classes Creator and PublishClip).
Use 'product' instead of 'subset'.
Marked base classes to be skipped during discovery.
Don't use "safe getters" for settings to make sure settings are actually used.

Testing notes:

This is untested PR from my side, please make sure it is fully reviewed.

Basics

Use ayon-core >= 1.8.0 or current develop if is not released yet.
Upload the addon to server to use new settings model.
Existing workfiles should load up and should be possible to publish.
Creating new instances should work as expected.

Product types

Define product types for plate and audio in settings.
Publisher should show selection of them in pre-create attributes.
Create them.
Product name should use the product type in name (if template defines that).
Publish the instances.
Loader tool should show the product type and product base type in UI.

…ugin

rdelillo

Tested locally, the following worked with the change I've suggested:

rdelillo · 2026-03-16T14:45:02Z

client/ayon_resolve/api/plugin.py

-        self.product_name = self.product_type + self.variant.capitalize()
+        # create product name for publishing
+        # TODO: Use creator `get_product_name` to correctly define name
+        self.product_name = self.product_base_type + self.variant.capitalize()


I had to revert this to make it work for me. Not sure if this is right but PublishableClip.product_base_type does not exist.

Suggested change

self.product_name = self.product_base_type + self.variant.capitalize()

self.product_name = self.product_type + self.variant.capitalize()

Changed product_type to plate_product_type which is what it actually holds.

jakubjezek001 · 2026-03-20T10:52:45Z

client/ayon_resolve/api/plugin.py


        self.hierarchy_data = {
-            key: get(key) or self.timeline_item_default_data[key]
+            key: get(key, self.timeline_item_default_data[key])


This might not be related but this is happening to me now:

Traceback (most recent call last): File "C:\CODE\__YNPUT\ayon-core\client\ayon_core\pipeline\create\context.py", line 2344, in _create_with_unified_error result = creator.create(*args, **kwargs) File "C:\CODE\__YNPUT\ayon-resolve\client\ayon_resolve\plugins\create\create_shot_clip.py", line 617, in create publish_clip = PublishableClip( File "C:\CODE\__YNPUT\ayon-resolve\client\ayon_resolve\api\plugin.py", line 407, in __init__ self._populate_attributes() File "C:\CODE\__YNPUT\ayon-resolve\client\ayon_resolve\api\plugin.py", line 502, in _populate_attributes self.hierarchy_data = { File "C:\CODE\__YNPUT\ayon-resolve\client\ayon_resolve\api\plugin.py", line 503, in <dictcomp> key: get(key, self.timeline_item_default_data[key]) KeyError: 'folder'

Actually looking into code, I am not sure how this could work before. The default value points only to _folder_

fixed in the commit

- Change hierarchy data lookup to use underscore-prefixed keys with fallback to empty string - Use plate_product_type instead of product_base_type for product name - Extract product type enum creation into _add_product_type_enum method - Remove trailing whitespace

jakubjezek001

I could not resist to commit some enhancements and fixes @iLLiCiTiT appologize for interfering with your great work. This was working for me and the position at Creator attributes is much better this way.

jakubjezek001 · 2026-03-20T12:55:05Z

client/ayon_resolve/api/plugin.py

-        self.product_name = self.product_type + self.variant.capitalize()
+        # create product name for publishing
+        # TODO: Use creator `get_product_name` to correctly define name
+        self.product_name = self.product_base_type + self.variant.capitalize()


Suggested change

self.product_name = self.product_base_type + self.variant.capitalize()

self.product_name = self.plate_product_type + self.variant.capitalize()

this is inherited from https://github.com/ynput/ayon-resolve/pull/83/changes#diff-dbca93e0046aac9618a03741fb59f6e8795e66126b815774e9eaa88f1edfc3adR492

jakubjezek001 · 2026-03-20T12:56:04Z

client/ayon_resolve/api/plugin.py


        self.hierarchy_data = {
-            key: get(key) or self.timeline_item_default_data[key]
+            key: get(key, self.timeline_item_default_data[key])


Actually looking into code, I am not sure how this could work before. The default value points only to _folder_

iLLiCiTiT added 23 commits March 5, 2026 14:39

change inheritance of 'ResolvePublishCreator'

2f9b424

remove backwards compatibility

6aa76c8

added some attributes to base classes

796d67f

use base type for product name

cc30323

don't use .get to access settings

63f3dbf

use product base type and product type in editorial package create pl…

0dec069

…ugin

use product base type for product type

2833d19

import base plugins

2339f76

add type hints

757ee4e

use product instead of subset

a390624

remove 'newAssetPublishing'

e74523d

create instances with all data

596a984

simplify check for enabled create plugins

98667f6

remove unused arguments

729d57f

fill plate product type and product base type

6ac5d16

remove productType attribute

5d1edde

use class attribute to get identifiers

92782ef

move apply settings to only plugin which is using it

f950adb

don't use safe access to settings keys

a09079c

added settings for product types

f63588d

use product type settings

21d21c8

define product base types as filters for load plugins

30eb757

remove unnecessary 'get_dynamic_data'

576d50d

iLLiCiTiT added bump minor type: enhancement Improvement of existing functionality or minor addition labels Mar 5, 2026

iLLiCiTiT requested review from BigRoy, antirotor and rdelillo March 5, 2026 15:45

iLLiCiTiT self-assigned this Mar 5, 2026

iLLiCiTiT requested a review from jakubjezek001 March 5, 2026 16:03

rdelillo reviewed Mar 16, 2026

View reviewed changes

iLLiCiTiT added 3 commits March 17, 2026 16:13

use plate product type

d403286

change how helper 'get' works

28d71aa

fill product type and audio type back to precreate data

5b63907

jakubjezek001 reviewed Mar 20, 2026

View reviewed changes

jakubjezek001 approved these changes Mar 20, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🏛️Product base types: Product types and base types#83

🏛️Product base types: Product types and base types#83
iLLiCiTiT wants to merge 27 commits intodevelopfrom
enhancement/product-base-types

iLLiCiTiT commented Mar 5, 2026 •

edited

Loading

Uh oh!

rdelillo left a comment

Uh oh!

rdelillo Mar 16, 2026

Uh oh!

iLLiCiTiT Mar 17, 2026

Uh oh!

jakubjezek001 Mar 20, 2026

Uh oh!

jakubjezek001 Mar 20, 2026

Uh oh!

jakubjezek001 Mar 20, 2026

Uh oh!

jakubjezek001 left a comment

Uh oh!

jakubjezek001 Mar 20, 2026

Uh oh!

jakubjezek001 Mar 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	self.product_name = self.product_base_type + self.variant.capitalize()
	self.product_name = self.product_type + self.variant.capitalize()

	self.product_name = self.product_base_type + self.variant.capitalize()
	self.product_name = self.plate_product_type + self.variant.capitalize()

Conversation

iLLiCiTiT commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog Description

Additional review information

Testing notes:

Basics

Product types

Uh oh!

rdelillo left a comment

Choose a reason for hiding this comment

Uh oh!

rdelillo Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

iLLiCiTiT Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

jakubjezek001 Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

jakubjezek001 Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

jakubjezek001 Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

jakubjezek001 left a comment

Choose a reason for hiding this comment

Uh oh!

jakubjezek001 Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

jakubjezek001 Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

iLLiCiTiT commented Mar 5, 2026 •

edited

Loading