Skip to content

fix(ui): avoid modal path mapping errors#520

Merged
deribaucourt merged 1 commit into
yoctoproject:stagingfrom
gcomneno:inspect/issue-441-nonmodal-path-error
May 22, 2026
Merged

fix(ui): avoid modal path mapping errors#520
deribaucourt merged 1 commit into
yoctoproject:stagingfrom
gcomneno:inspect/issue-441-nonmodal-path-error

Conversation

@gcomneno
Copy link
Copy Markdown
Contributor

Fixes #441.

The container path mapping error was displayed as a modal VS Code error dialog.

If that dialog cannot be dismissed correctly, it can block the full VS Code UI and force the user to kill the application.

This change keeps the existing error notification and diagnostic details, but avoids using a modal dialog for the container path mapping failure.

Only the path mapping error in BitBakeProjectScanner was changed. Other modal dialogs remain unchanged.

Validation:

  • npm run compile
  • npm run jest -- client/src/tests/unit-tests/driver/path-mapping-errors.test.ts

@gcomneno gcomneno force-pushed the inspect/issue-441-nonmodal-path-error branch from 06290e7 to 8762b20 Compare May 15, 2026 16:07
Comment thread client/src/__tests__/unit-tests/driver/path-mapping-errors.test.ts Outdated
Comment thread client/src/driver/BitBakeProjectScanner.ts Outdated
@gcomneno gcomneno force-pushed the inspect/issue-441-nonmodal-path-error branch from 8762b20 to d9fd673 Compare May 22, 2026 09:16
@gcomneno
Copy link
Copy Markdown
Contributor Author

I addressed the review comments:

  • moved the path mapping error test into scanner-unit.test.ts
  • removed the separate path-mapping-errors.test.ts file
  • removed the non-modal detail usage, since VS Code only renders detail for modal messages
  • moved the actionable path mapping explanation into the main error message
  • kept the message non-modal by calling showErrorMessage() with only the message argument

Local validation:

  • npm run compile
  • npm run lint
  • npm run jest -- client/src/tests/unit-tests/driver/scanner-unit.test.ts

Copy link
Copy Markdown
Member

@deribaucourt deribaucourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rendering is ok.
Thanks again for your awesome contribution!

The next step for me will be to publish a new release with all that's been merged so far.
I think I'll be reaching out to the Yocto maintainers to prioritize the next steps of the backlog.

@deribaucourt deribaucourt merged commit 21bc9f4 into yoctoproject:staging May 22, 2026
5 checks passed
@gcomneno
Copy link
Copy Markdown
Contributor Author

Thanks a lot for the review and merge!

I'm really glad these fixes could help unblock the release path. Looking forward to the next backlog priorities once you have aligned with the Yocto maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Blocking dialogue

2 participants