forked from ssut/code-push-cloudflare-workers
-
Notifications
You must be signed in to change notification settings - Fork 0
[COS-3202] code push 로컬 cache 구현 및 빈도수 가 높은 쿼리에 caching 로직 추가 #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mu29
approved these changes
Apr 21, 2025
Collaborator
mu29
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
캐시 크기가 얼마나 늘어날까요? 요청이 잦아서 워커 인스턴스는 계속 재활용될 것 같고, 혹시 계속 증가한다면 LRU가 필요할 수도요 ㅎㅎ https://github.com/isaacs/node-lru-cache
당장은 괜찮을 것 같긴 합니당
Author
|
@mu29 좀 돌려 봐야 알거 같아요! 근데 저희 앱 밖에 없고 제일 큰게 길이가 200정도 되는 array이라 말씀대로 지금 당장은 괜찮을거 같습니다! |
Author
|
@mu29 r2 권한때문에 배포도 안되네요..ㅎㅎ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COS-3202