fix: use mktemp to prevent /tmp race condition#4
Closed
Jah-yee wants to merge 1 commit intoythx-101:masterfrom
Closed
fix: use mktemp to prevent /tmp race condition#4Jah-yee wants to merge 1 commit intoythx-101:masterfrom
Jah-yee wants to merge 1 commit intoythx-101:masterfrom
Conversation
- Use mktemp to create unique temp file instead of hardcoded path - Prevents potential race condition if another process creates /tmp/ask-search-wrapper - Follows security best practices for temporary file handling
Owner
|
Duplicate of #3, same fix. Thanks for the contribution! 🦞 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security Note
This fix addresses a potential TOCTOU (time-of-check to time-of-use) race condition in the install script.