-
Notifications
You must be signed in to change notification settings - Fork 26
Oxidized.setup_logger retired #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughOxidized.setup_logger calls were removed from CLI initialization and example usage in documentation; CHANGELOG, README, and Changes
Sequence Diagram(s)(omitted — changes are a simple removal of a single logger initialization call; control flow structure remains unchanged) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (3)
CHANGELOG.md(1 hunks)README.md(0 hunks)lib/oxidized/script/cli.rb(0 hunks)
💤 Files with no reviewable changes (2)
- lib/oxidized/script/cli.rb
- README.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: test (3.3)
- GitHub Check: test (3.2)
- GitHub Check: test (3.4)
- GitHub Check: test (3.1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (3)
CHANGELOG.md(1 hunks)README.md(0 hunks)lib/oxidized/script/cli.rb(0 hunks)
💤 Files with no reviewable changes (2)
- lib/oxidized/script/cli.rb
- README.md
| - fixed --list-models (@nickhilliard) | ||
| - return exception if host specification line returns no hosts (@nickhilliard) | ||
| - Remove Oxidized.setup_logger from CLI initialization (@nickhilliard) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick | 🔵 Trivial
Lowercase the verb for consistency within the section.
Line 13 starts with an uppercase "Remove", while lines 11–12 use lowercase verbs ("fixed", "return"). Align the capitalization for consistency.
- Remove Oxidized.setup_logger from CLI initialization (@nickhilliard)
+ remove Oxidized.setup_logger from CLI initialization (@nickhilliard)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - fixed --list-models (@nickhilliard) | |
| - return exception if host specification line returns no hosts (@nickhilliard) | |
| - Remove Oxidized.setup_logger from CLI initialization (@nickhilliard) | |
| - fixed --list-models (@nickhilliard) | |
| - return exception if host specification line returns no hosts (@nickhilliard) | |
| - remove Oxidized.setup_logger from CLI initialization (@nickhilliard) |
🤖 Prompt for AI Agents
In CHANGELOG.md around lines 11 to 13, the third entry ("Remove
Oxidized.setup_logger from CLI initialization") uses an uppercase verb while the
other entries use lowercase; change "Remove" to "remove" to match the lowercase
verb style for consistency within the section.
Pre-Request Checklist
rubocop --auto-correct)Description
Closes issue #73
Summary by CodeRabbit