Skip to content

Conversation

@nickhilliard
Copy link
Collaborator

@nickhilliard nickhilliard commented Nov 11, 2025

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • User-visible changes appended to CHANGELOG.md

Description

Closes issue #73

Summary by CodeRabbit

  • Bug Fixes
    • Removed an obsolete logger initialization from the startup flow to prevent redundant logging behavior.
  • Documentation
    • Updated usage examples and README to remove the now-removed logger setup call so examples reflect current startup behavior.

@coderabbitai
Copy link

coderabbitai bot commented Nov 11, 2025

Walkthrough

Oxidized.setup_logger calls were removed from CLI initialization and example usage in documentation; CHANGELOG, README, and lib/oxidized/script/cli.rb were updated to reflect that removal.

Changes

Cohort / File(s) Summary
Documentation
CHANGELOG.md, README.md
Removed Oxidized.setup_logger invocations from usage examples and updated changelog entry to reflect removal.
CLI Initialization
lib/oxidized/script/cli.rb
Removed the single Oxidized.setup_logger call executed after Config.load(@opts) in the CLI initialize flow.

Sequence Diagram(s)

(omitted — changes are a simple removal of a single logger initialization call; control flow structure remains unchanged)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • Verify no remaining code paths assume logger is initialized at CLI initialization.
  • Confirm logging is initialized elsewhere or intentionally deferred/deprecated.
  • Review README examples for completeness after logger removal.

Poem

🧹 A single call swept from the start,
Quiet logs now wait, a subtler art.
Docs and changelog whisper the change,
Small tidy steps across the range. ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Oxidized.setup_logger retired' directly matches the core change: removing Oxidized.setup_logger calls from CLI initialization, README examples, and the codebase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ad4a4ca and 2f08707.

📒 Files selected for processing (3)
  • CHANGELOG.md (1 hunks)
  • README.md (0 hunks)
  • lib/oxidized/script/cli.rb (0 hunks)
💤 Files with no reviewable changes (2)
  • lib/oxidized/script/cli.rb
  • README.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: test (3.3)
  • GitHub Check: test (3.2)
  • GitHub Check: test (3.4)
  • GitHub Check: test (3.1)

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2f08707 and 2fd1970.

📒 Files selected for processing (3)
  • CHANGELOG.md (1 hunks)
  • README.md (0 hunks)
  • lib/oxidized/script/cli.rb (0 hunks)
💤 Files with no reviewable changes (2)
  • lib/oxidized/script/cli.rb
  • README.md

Comment on lines 11 to +13
- fixed --list-models (@nickhilliard)
- return exception if host specification line returns no hosts (@nickhilliard)
- Remove Oxidized.setup_logger from CLI initialization (@nickhilliard)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

Lowercase the verb for consistency within the section.

Line 13 starts with an uppercase "Remove", while lines 11–12 use lowercase verbs ("fixed", "return"). Align the capitalization for consistency.

- Remove Oxidized.setup_logger from CLI initialization (@nickhilliard)
+ remove Oxidized.setup_logger from CLI initialization (@nickhilliard)
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- fixed --list-models (@nickhilliard)
- return exception if host specification line returns no hosts (@nickhilliard)
- Remove Oxidized.setup_logger from CLI initialization (@nickhilliard)
- fixed --list-models (@nickhilliard)
- return exception if host specification line returns no hosts (@nickhilliard)
- remove Oxidized.setup_logger from CLI initialization (@nickhilliard)
🤖 Prompt for AI Agents
In CHANGELOG.md around lines 11 to 13, the third entry ("Remove
Oxidized.setup_logger from CLI initialization") uses an uppercase verb while the
other entries use lowercase; change "Remove" to "remove" to match the lowercase
verb style for consistency within the section.

@nickhilliard nickhilliard merged commit f69446b into ytti:master Nov 12, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant