Open
Conversation
FSF headquarter moved. Update README.md accordingly and use the latest official GPLv1 text. The later only changes names in examples and replaces the FSF postal address by an hyperlink and does not alter the licensing terms.
The current algorithm used to determine the latest commit targeting specific files calls "git log" for each of these files. Since there is no index for that information, git runs through the log from the beginning until it finds the commit: the time spent to do this operation is then proportional to the number of files times the commit count. The current patch changes this algorithm to handle all files in a directory with a single "git log", drastically reducing the response time of a directory tree view.
Collaborator
Author
|
Any feelings about it ? Can I merge ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Yuki,
This time, the directory tree view is considerably accelerated.
I made some tests on a 32700-commits repository with a 1750-files directory (
tests/dataincurlrepository). the previous algorithm takes 2m10s, while the new one only 2.5s ! Although not very meaningful for small projects, it is very impressive for large ones likecurlorbinutils-gdb.There is a second commit to replace the outdated FSF postal address.
Cheers,
Patrick