Skip to content

feat: use brew for temurin java - #943

Merged
yxtay merged 1 commit into
mainfrom
feat/brew-temurin
Jul 29, 2026
Merged

feat: use brew for temurin java#943
yxtay merged 1 commit into
mainfrom
feat/brew-temurin

Conversation

@yxtay

@yxtay yxtay commented Jul 29, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Tooling Updates

    • Dependency and development tool upgrades now use uv when available, simplifying maintenance of installed command-line tools.
    • Global package and skill update workflows remain supported.
  • Environment Improvements

    • Homebrew setup now installs Temurin Java 17 for compatible development workflows.
    • Java 17 is managed through the package installation process rather than the previous tool configuration.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3c60c9f7-a2f1-4476-add1-9876ed149003

📥 Commits

Reviewing files that changed from the base of the PR and between 8cdd436 and 8ea809e.

📒 Files selected for processing (3)
  • bin/update-all.sh
  • chezmoi/.chezmoiscripts/run_before_brew_install.sh.tmpl
  • chezmoi/private_dot_config/mise/config.toml

📝 Walkthrough

Walkthrough

Updates the dependency upgrade command from mise to uv, adds Temurin JDK 17 to Homebrew installation, and removes Java from mise configuration.

Changes

Toolchain updates

Layer / File(s) Summary
Upgrade and Java provisioning
bin/update-all.sh, chezmoi/.chezmoiscripts/run_before_brew_install.sh.tmpl, chezmoi/private_dot_config/mise/config.toml
Uses uv tool upgrade --all when available, adds temurin@17 to the Homebrew bundle, and removes the mise Java tool mapping.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Poem

A bunny hops where Java once grew,
Temurin joins the brew list too.
Mise steps aside, uv takes flight,
Updating tools with carrots bright.
Hop, hop—versioned just right!

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/brew-temurin

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yxtay
yxtay merged commit 6ebfe74 into main Jul 29, 2026
17 of 19 checks passed
@yxtay
yxtay deleted the feat/brew-temurin branch July 29, 2026 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant