Fix standby bootstrap when standby_primary_slot_name is set#1200
Open
mdoulabi1 wants to merge 1 commit into
Open
Fix standby bootstrap when standby_primary_slot_name is set#1200mdoulabi1 wants to merge 1 commit into
mdoulabi1 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
standby_primary_slot_nameto the standby bootstrap helperpg_receivewalbefore postgres startup and preservewal_fastrestore_command.shfor localwal_fastreplay during standby bootstrapProblem
When
standby_primary_slot_nameis configured, the bootstrap helper may not use the slot correctly, or the handoff from bootstrap WAL collection to postgres recovery may fail. This can lead to:Test
basebackup.shrestore_command.shreplication slot "..." is activerequested WAL segment ... has already been removed