Skip to content

feat: expo sdk 54#232

Open
zaniluca wants to merge 3 commits intomasterfrom
expo54
Open

feat: expo sdk 54#232
zaniluca wants to merge 3 commits intomasterfrom
expo54

Conversation

@zaniluca
Copy link
Owner

No description provided.

@zaniluca zaniluca marked this pull request as ready for review February 15, 2026 14:58
Comment on lines +24 to +28
if (data?.url) {
url = data.url as string;
} else if (data?.nid) {
url = Linking.createURL(`notifications/${data.nid}`);
} else {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Notification deep linking is broken when the app is launched from a killed state because the handling logic was removed from getInitialURL.
Severity: CRITICAL

Suggested Fix

Restore the logic within the getInitialURL function in src/navigation/linking.ts. It should await Notifications.getLastNotificationResponseAsync() and process the response to return the correct initial deep link path, ensuring notification taps from a killed app state are handled correctly.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: src/hooks/use-notification-deep-link.ts#L24-L28

Potential issue: The logic to handle notification deep links when the app is launched
from a killed state has been removed from `getInitialURL`. Previously, `getInitialURL`
would check for a notification response using
`Notifications.getLastNotificationResponseAsync()`. The new implementation returns
`null` and relies on the `useNotificationDeepLink` hook, which executes too late in the
app's startup sequence to handle this cold-start scenario. Consequently, when a user
taps a notification while the app is not running, they will be directed to the default
initial screen instead of the content specified in the notification.

Did we get this right? 👍 / 👎 to inform future reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant