Conversation
Comment on lines
+24
to
+28
| if (data?.url) { | ||
| url = data.url as string; | ||
| } else if (data?.nid) { | ||
| url = Linking.createURL(`notifications/${data.nid}`); | ||
| } else { |
There was a problem hiding this comment.
Bug: Notification deep linking is broken when the app is launched from a killed state because the handling logic was removed from getInitialURL.
Severity: CRITICAL
Suggested Fix
Restore the logic within the getInitialURL function in src/navigation/linking.ts. It should await Notifications.getLastNotificationResponseAsync() and process the response to return the correct initial deep link path, ensuring notification taps from a killed app state are handled correctly.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: src/hooks/use-notification-deep-link.ts#L24-L28
Potential issue: The logic to handle notification deep links when the app is launched
from a killed state has been removed from `getInitialURL`. Previously, `getInitialURL`
would check for a notification response using
`Notifications.getLastNotificationResponseAsync()`. The new implementation returns
`null` and relies on the `useNotificationDeepLink` hook, which executes too late in the
app's startup sequence to handle this cold-start scenario. Consequently, when a user
taps a notification while the app is not running, they will be directed to the default
initial screen instead of the content specified in the notification.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.