[C]Worthy OAE dataset example#557
Draft
TomNicholas wants to merge 11 commits intozarr-developers:mainfrom
Draft
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/releases.rstA list of everything about this demo that is janky and should be fixed before merging, in order of most to least janky:
RetryingFunctionExecutorlithops-cloud/lithops#1429open_virtual_dataset#625developbranch of VirtualiZarropen_virtual_mfdataset#569combine_by_coordsdidn't work because it triggered a reindex, and I don't know whycachePR generates http URLs, but Icechunk can't store them yet (Add support for virtual chunks via Http/Https earth-mover/icechunk#526) - EDIT: for cases that don't require auth this should now work, but is untested--provenancekwarg to my local docker build and I don't actually know if I need that.lithops_configbecause they seem not to be discovered when set as environment variables in the notebookopen_virtual_mfdatasetfunction is not documented, but was added in Add open_virtual_mfdataset #349 (docs added in Docs onopen_virtual_mfdatasetand scaling #590)(EDIT: This one isn't important)open_virtual_mfdatasetparallelkwarg is different to theparallelkwarg forxr.open_mfdataset, because the generalization here should be merged upstream Use lithops to parallelize open_mfdataset pydata/xarray#9932I have workarounds for basically all of them, but they should all be understood and fixed.